From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, rjw@rjwysocki.net, lenb@kernel.org,
jbacik@fb.com, jikos@kernel.org, benjamin.tissoires@redhat.com,
manish.chopra@cavium.com, rahul.verma@cavium.com,
Dept-GELinuxNICDev@cavium.com, harish.patil@cavium.com,
cascardo@holoscopio.com, don@syst.com.br, dvhart@infradead.org,
andy@infradead.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
nbd-general@lists.sourceforge.net, linux-input@vger.kernel.org,
netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 6/6] power: supply: make device_attribute const
Date: Tue, 29 Aug 2017 10:44:21 +0200 [thread overview]
Message-ID: <20170829084421.4nm3uoswlx2ftc5m@earth> (raw)
In-Reply-To: <1503315792-14837-7-git-send-email-bhumirks@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
Hi,
On Mon, Aug 21, 2017 at 05:13:12PM +0530, Bhumika Goyal wrote:
> Make these const as they are only passed as an argument to the
> function device_create_file and device_remove_file and the corresponding
> arguments are of type const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/olpc_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/olpc_battery.c b/drivers/power/supply/olpc_battery.c
> index fc20ca3..3bc2eea 100644
> --- a/drivers/power/supply/olpc_battery.c
> +++ b/drivers/power/supply/olpc_battery.c
> @@ -559,7 +559,7 @@ static ssize_t olpc_bat_error_read(struct device *dev,
> return sprintf(buf, "%d\n", ec_byte);
> }
>
> -static struct device_attribute olpc_bat_error = {
> +static const struct device_attribute olpc_bat_error = {
> .attr = {
> .name = "error",
> .mode = S_IRUGO,
> --
> 1.9.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-29 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 11:43 [PATCH 0/6] drivers: make device_attribute const Bhumika Goyal
2017-08-21 11:43 ` [PATCH 1/6] ACPI: " Bhumika Goyal
2017-08-28 20:56 ` Rafael J. Wysocki
2017-08-21 11:43 ` [PATCH 2/6] nbd: " Bhumika Goyal
2017-08-28 21:21 ` Jens Axboe
2017-08-21 11:43 ` [PATCH 3/6] hid: " Bhumika Goyal
2017-09-06 8:57 ` Jiri Kosina
2017-08-21 11:43 ` [PATCH 4/6] qlogic: " Bhumika Goyal
2017-08-21 17:25 ` David Miller
2017-08-21 17:26 ` Bhumika Goyal
2017-08-21 11:43 ` [PATCH 5/6] platform/x86: " Bhumika Goyal
2017-08-21 13:22 ` Thadeu Lima de Souza Cascardo
2017-08-30 19:18 ` Andy Shevchenko
2017-08-21 11:43 ` [PATCH 6/6] power: supply: " Bhumika Goyal
2017-08-29 8:44 ` Sebastian Reichel [this message]
2017-08-21 12:28 ` [PATCH 0/6] drivers: " Rafael J. Wysocki
2017-08-21 12:57 ` Bhumika Goyal
2017-08-21 12:55 ` Bhumika Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829084421.4nm3uoswlx2ftc5m@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bhumirks@gmail.com \
--cc=cascardo@holoscopio.com \
--cc=don@syst.com.br \
--cc=dvhart@infradead.org \
--cc=harish.patil@cavium.com \
--cc=jbacik@fb.com \
--cc=jikos@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rahul.verma@cavium.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).