From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751805AbdH2VvW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Aug 2017 17:51:22 -0400
Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]:38488 "EHLO
        lb1-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751378AbdH2VvU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Aug 2017 17:51:20 -0400
Date: Tue, 29 Aug 2017 23:51:12 +0200
From: Antony Antony <antony@phenome.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Code Kipper <codekipper@gmail.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus
 2
Message-ID: <20170829215112.4p34hryd7kmhhr6w@AntonyAntony.local>
References: <20170824231716.2623-1-antony@phenome.org>
 <20170825103242.5665-1-antony@phenome.org>
 <CAEKpxBkUKGUQR2Vh1+Ci4wbB-+x48nRjLmWME2EUECCHuuwsmQ@mail.gmail.com>
 <20170828121644.p7mknytubsajzctg@AntonyAntony.local>
 <BF2F26DC-7014-4AF6-9C02-D1038A0FDA38@aosc.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BF2F26DC-7014-4AF6-9C02-D1038A0FDA38@aosc.io>
User-Agent: NeoMutt/20170602 (1.8.3)
X-CMAE-Envelope: MS4wfG/m26XzlmyJWxZvDhuYdIRugcFNc1ayVVUnSXnNwt1PIrhfHc+AvheoR0J9ydnsrvcs0C7B46OQaI4PJ1oNWLeDU0LW8lpQuR1iFQQTsSB/fYrNIDvk
 cwEZRM1SJij6bky+syb1HYX+p5x/po7JfKQ7U0xF9+3Zy/J6+O12/qrwuYRWgYNWop3bugMPkcFiB4nYX4iyK9kwYGTAxh1rh6yYQ1io2RNQCThkAPcvUQ2q
 rmEuAwmGAm8T9Uc2u/97K5w+cK+dAPVL7/X5wBeb/9h5u5vHdYBW30Ui8Fa3Oh3j4xscfn1s2GIcmBuM0kKhbL7SVZFVkg9Vj2gSKqg6k2hMf8nDRw2RWTC7
 zCLBZexO+hkrjSNW/GfHLNAENtcC8R8bvASslkDevzSqYrYw5xGVsV9/V6BPrbOgw9Mecb0g
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Mon, Aug 28, 2017 at 08:18:58PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2017年8月28日 GMT+08:00 下午8:16:44, Antony Antony <antony@phenome.org> 写到:
> >On Fri, Aug 25, 2017 at 03:28:41PM +0200, Code Kipper wrote:
> >> On 25 August 2017 at 12:32, Antony Antony <antony@phenome.org> wrote:
> >
> >> > +
> >> > +       brcmf: bcrmf@1 {
> >> > +               reg = <1>;
> >> > +               compatible = "brcm,bcm4329-fmac";
> >> > +       };
> >> Incorrect wifi chip - just deliver what you've tested.
> 
> Nope, this compatible is required by the dt binding, see the
> binding document or other DTs with brcmfmac SDIO.

Icenowy,

Thanks for pointing out brcm,bcm43430-fmac is missing in Documenation.
I just send a patch to wireless brcmfmac maintainers. 

https://patchwork.kernel.org/patch/9928387/

Would this work?

> Please complain to brcmfmac maintainers.

Lets see how it shakes out. 

regards,
-antony