From: Borislav Petkov <bp@suse.de>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: "Baicar, Tyler" <tbaicar@codeaurora.org>,
Tony Luck <tony.luck@intel.com>,
rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com,
james.morse@arm.com, prarit@redhat.com, punit.agrawal@arm.com,
shiju.jose@huawei.com, andriy.shevchenko@linux.intel.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux PCI <linux-pci@vger.kernel.org>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] acpi: apei: call into AER handling regardless of severity
Date: Wed, 30 Aug 2017 19:02:06 +0200 [thread overview]
Message-ID: <20170830170205.wf7q6hfcw4jhbpmu@pd.tnic> (raw)
In-Reply-To: <af5dc902-faca-a7a1-6781-95ff82d5d8fd@codeaurora.org>
On Wed, Aug 30, 2017 at 11:31:06AM -0400, Sinan Kaya wrote:
> I see. We should probably try to do something only if GHES_SEV_CORRECTED or
> GHES_SEV_RECOVERABLE.
>
> If somebody wants to crash the system with GHES_SEV_PANIC, there is no point
> in doing additional work.
Makes sense.
Whatever we do, I'd like to have this all nicely documented *why* we're
doing the recovery policy we're doing.
> Sounds good. Do you still want to do PCIe recovery in the case of
> GHES_SEV_PANIC or if some FW returns GHES_SEV_NO?
So I read GHES_SEV_PANIC as: we should panic and stop any processing
whatsoever ASAP in order to avoid further error propagation. So doing
recovery there might *actually* be a bad idea.
GHES_SEV_NO would map to AER_CORRECTABLE and I think that would mean,
print the error to let the user know but no need to recover because no
harm was done.
I *think*.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2017-08-30 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 17:11 [PATCH] acpi: apei: call into AER handling regardless of severity Tyler Baicar
2017-08-28 20:52 ` Rafael J. Wysocki
2017-08-29 8:20 ` Borislav Petkov
2017-08-29 21:27 ` Baicar, Tyler
2017-08-29 22:19 ` Borislav Petkov
2017-08-29 22:34 ` Sinan Kaya
2017-08-30 10:16 ` Borislav Petkov
2017-08-30 14:05 ` Sinan Kaya
2017-08-30 15:16 ` Borislav Petkov
2017-08-30 15:31 ` Sinan Kaya
2017-08-30 15:42 ` Baicar, Tyler
2017-08-30 17:14 ` Borislav Petkov
2017-08-30 18:09 ` Baicar, Tyler
2017-08-30 17:02 ` Borislav Petkov [this message]
2017-08-29 23:06 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830170205.wf7q6hfcw4jhbpmu@pd.tnic \
--to=bp@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=prarit@redhat.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).