From: Artem Savkov <asavkov@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org
Subject: Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem
Date: Thu, 31 Aug 2017 14:19:37 +0200 [thread overview]
Message-ID: <20170831121908.kin3mm25ebszhpvn@shodan.usersys.redhat.com> (raw)
In-Reply-To: <20170831120951.hqlu2ai5i7hly7nk@dhcp22.suse.cz>
On Thu, Aug 31, 2017 at 02:09:51PM +0200, Michal Hocko wrote:
> On Thu 31-08-17 13:10:06, Artem Savkov wrote:
> > Hi Michal,
> >
> > On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote:
> > > The previous patch is insufficient. drain_all_stock can still race with
> > > the memory offline callback and the underlying memcg disappear. So we
> > > need to be more careful and pin the css on the memcg. This patch
> > > instead...
> >
> > Tried this on top of rc7 and it does fix the splat for me.
>
> Thanks for testing! Can I assume your Tested-by?
Didn't test much more than the case that was causing it, but yes.
Reported-and-tested-by: Artem Savkov <asavkov@redhat.com>
--
Regards,
Artem
next prev parent reply other threads:[~2017-08-31 12:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 14:09 possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem Artem Savkov
2017-08-15 19:01 ` Paul E. McKenney
2017-08-16 13:39 ` Laurent Dufour
2017-08-16 15:36 ` Artem Savkov
2017-08-16 15:40 ` Laurent Dufour
2017-08-16 14:07 ` Thomas Gleixner
2017-08-30 14:15 ` Michal Hocko
2017-08-30 15:43 ` Michal Hocko
2017-08-31 11:10 ` Artem Savkov
2017-08-31 12:09 ` Michal Hocko
2017-08-31 12:19 ` Artem Savkov [this message]
2017-09-04 14:03 ` Michal Hocko
2017-09-05 8:19 ` Thomas Gleixner
2017-09-05 10:23 ` Michal Hocko
2017-09-05 11:04 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831121908.kin3mm25ebszhpvn@shodan.usersys.redhat.com \
--to=asavkov@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).