From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
kan.liang@intel.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, jolsa@redhat.com,
tglx@linutronix.de, eranian@google.com, ak@linux.intel.com,
mpe@ellerman.id.au
Subject: Re: [PATCH V8] perf: Add PERF_SAMPLE_PHYS_ADDR
Date: Thu, 31 Aug 2017 13:43:27 -0300 [thread overview]
Message-ID: <20170831164327.GI4831@kernel.org> (raw)
In-Reply-To: <20170829114553.mwd6btebikpoh6fi@hirez.programming.kicks-ass.net>
Em Tue, Aug 29, 2017 at 01:45:53PM +0200, Peter Zijlstra escreveu:
> On Tue, Aug 29, 2017 at 05:05:15PM +0530, Madhavan Srinivasan wrote:
> >
> >
> > On Tuesday 29 August 2017 06:22 AM, kan.liang@intel.com wrote:
> > > From: Kan Liang <kan.liang@intel.com>
> > >
> > > For understanding how the workload maps to memory channels and hardware
> > > behavior, it's very important to collect address maps with physical
> > > addresses. For example, 3D XPoint access can only be found by filtering
> > > the physical address.
> > >
> > > Add a new sample type for physical address.
> > >
> > > perf already has a facility to collect data virtual address. This patch
> > > introduces a function to convert the virtual address to physical address.
> > > The function is quite generic and can be extended to any architecture as
> > > long as a virtual address is provided.
> > > - For kernel direct mapping addresses, virt_to_phys is used to convert
> > > the virtual addresses to physical address.
> > > - For user virtual addresses, __get_user_pages_fast is used to walk the
> > > pages tables for user physical address.
> > > - This does not work for vmalloc addresses right now. These are not
> > > resolved, but code to do that could be added.
> > >
> > > The new sample type requires collecting the virtual address. The
> > > virtual address will not be output unless SAMPLE_ADDR is applied.
> > >
> > > For security, the physical address can only be exposed to root or
> > > privileged user.
> >
> > Tested-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
You mean you tested this together with Kan's v2 perf tools patches? If
that is so I'll add this tested-by to those patches, ok?
> Thanks maddy!
next prev parent reply other threads:[~2017-08-31 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 0:52 [PATCH V8] perf: Add PERF_SAMPLE_PHYS_ADDR kan.liang
2017-08-29 11:35 ` Madhavan Srinivasan
2017-08-29 11:45 ` Peter Zijlstra
2017-08-31 16:43 ` Arnaldo Carvalho de Melo [this message]
[not found] ` <f006309a-9c95-6d31-1b0b-107179042c9b@linux.vnet.ibm.com>
[not found] ` <37D7C6CF3E00A74B8858931C1DB2F077537A7BB6@SHSMSX103.ccr.corp.intel.com>
2017-09-01 13:02 ` Liang, Kan
2017-08-29 14:22 ` [tip:perf/core] perf/core, x86: " tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831164327.GI4831@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).