From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Support standalone metrics and metric groups for perf
Date: Fri, 1 Sep 2017 19:36:05 +0200 [thread overview]
Message-ID: <20170901173605.GC32113@krava> (raw)
In-Reply-To: <20170901172618.GA30560@krava>
On Fri, Sep 01, 2017 at 07:26:18PM +0200, Jiri Olsa wrote:
> On Thu, Aug 31, 2017 at 12:40:25PM -0700, Andi Kleen wrote:
>
> SNIP
>
> >
> > % perf stat -M Summary --metric-only -a sleep 1
> >
> > Performance counter stats for 'system wide':
> >
> > Instructions CLKS CPU_Utilization GFLOPs SMT_2T_Utilization Kernel_Utilization
> > 317614222.0 1392930775.0 0.0 0.0 0.2 0.1
> >
> > 1.001497549 seconds time elapsed
> >
> > % perf stat -M GFLOPs flops
> >
> > Performance counter stats for 'flops':
> >
> > 3,999,541,471 fp_comp_ops_exe.sse_scalar_single # 1.2 GFLOPs (66.65%)
> > 14 fp_comp_ops_exe.sse_scalar_double (66.65%)
> > 0 fp_comp_ops_exe.sse_packed_double (66.67%)
> > 0 fp_comp_ops_exe.sse_packed_single (66.70%)
> > 0 simd_fp_256.packed_double (66.70%)
> > 0 simd_fp_256.packed_single (66.67%)
>
> looks like some events are probably crossing some
> output boundaries we have:
>
> [jolsa@krava perf]$ sudo ./perf stat -M SMT -I 1000
> # time counts unit events
> 1.000565706 408,879,985 inst_retired.any # 0.7 CoreIPC (66.68%)
> 1.000565706 1,120,999,114 cpu_clk_unhalted.thread_any (66.68%)
> 1.000565706 701,285,312 cycles (66.68%)
> 1.000565706 1,148,325,740 cpu_clk_unhalted.thread_any # 574162870.0 CORE_CLKS (66.67%)
> 1.000565706 711,565,247 cpu_clk_unhalted.thread (66.66%)
> 1.000565706 24,057,590 cpu_clk_thread_unhalted.one_thread_active # 0.3 SMT_2T_Utilization (66.67%)
> 1.000565706 65,753,475 cpu_clk_thread_unhalted.ref_xclk_any (66.67%)
> ^C 1.349436822 21,198,385 inst_retired.any # 0.1 CoreIPC (66.70%)
> 1.349436822 112,740,282 cpu_clk_unhalted.thread_any (66.70%)
> 1.349436822 84,509,414 cycles (66.70%)
> 1.349436822 108,181,315 cpu_clk_unhalted.thread_any # 54090657.5 CORE_CLKS (66.62%)
> 1.349436822 79,700,353 cpu_clk_unhalted.thread (66.61%)
> 1.349436822 3,911,698 cpu_clk_thread_unhalted.one_thread_active # 0.8 SMT_2T_Utilization (66.69%)
> 1.349436822 14,739,671 cpu_clk_thread_unhalted.ref_xclk_any (66.69%)
>
>
> could you please check on that and maybe shift the alignment for the longest name?
other than this the rest of the patchset looks ok to me
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2017-09-01 17:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 19:40 Support standalone metrics and metric groups for perf Andi Kleen
2017-08-31 19:40 ` [PATCH v3 01/11] perf, tools: Support weak groups Andi Kleen
2017-09-01 16:57 ` Jiri Olsa
2017-09-01 17:00 ` Jiri Olsa
2017-09-04 16:51 ` Arnaldo Carvalho de Melo
2017-09-22 16:28 ` [tip:perf/core] perf tools: Support weak groups in 'perf stat' tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 02/11] perf, tools: Support metric_group and no event name in json parser Andi Kleen
2017-09-22 16:29 ` [tip:perf/core] perf vendor events: Support metric_group and no event name in JSON parser tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 03/11] perf, tools, stat: Factor out generic metric printing Andi Kleen
2017-09-22 16:29 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 04/11] perf, tools: Print generic metric header even for failed expressions Andi Kleen
2017-09-22 16:30 ` [tip:perf/core] perf stat: " tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 05/11] perf, tools: Extract function to get json alias map Andi Kleen
2017-09-22 16:30 ` [tip:perf/core] perf pmu: Extract function to get JSON " tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen
2017-09-04 17:11 ` Arnaldo Carvalho de Melo
2017-09-04 17:37 ` Andi Kleen
2017-09-05 18:09 ` Arnaldo Carvalho de Melo
2017-09-05 18:16 ` Arnaldo Carvalho de Melo
2017-09-05 18:32 ` Arnaldo Carvalho de Melo
2017-09-05 18:19 ` Andi Kleen
2017-09-05 18:52 ` Arnaldo Carvalho de Melo
2017-09-05 19:52 ` Andi Kleen
2017-09-05 20:07 ` Arnaldo Carvalho de Melo
2017-09-05 20:37 ` Andi Kleen
2017-09-08 18:10 ` Arnaldo Carvalho de Melo
2017-09-08 19:08 ` Andi Kleen
2017-09-11 14:05 ` Arnaldo Carvalho de Melo
2017-09-22 16:37 ` [tip:perf/core] perf vendor events: Add JSON metrics for Broadwell tip-bot for Andi Kleen
2017-09-22 16:38 ` [tip:perf/core] perf vendor events: Add JSON metrics for Skylake tip-bot for Andi Kleen
2017-09-22 16:38 ` [tip:perf/core] perf vendor events: Add JSON metrics for Sandy Bridge tip-bot for Andi Kleen
2017-09-22 16:31 ` [tip:perf/core] perf stat: Support JSON metrics in perf stat tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 07/11] perf, tools, list: Add metric groups to perf list Andi Kleen
2017-09-22 16:31 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-10-13 14:50 ` [PATCH v3 07/11] perf, tools, " Arnaldo Carvalho de Melo
2017-08-31 19:40 ` [PATCH v3 08/11] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen
2017-09-22 16:31 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 09/11] perf, tools, stat: Support duration_time for metrics Andi Kleen
2017-09-22 16:32 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 10/11] perf, tools, stat: Hide internal duration_time counter Andi Kleen
2017-09-22 16:32 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-31 19:40 ` [PATCH v3 11/11] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen
2017-09-22 16:33 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-09-01 17:26 ` Support standalone metrics and metric groups for perf Jiri Olsa
2017-09-01 17:36 ` Jiri Olsa [this message]
2017-09-01 17:42 ` Andi Kleen
2017-09-01 17:50 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-07-24 23:40 Andi Kleen
2017-07-26 14:15 ` Jiri Olsa
2017-07-26 15:38 ` Andi Kleen
2017-07-28 8:48 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901173605.GC32113@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).