LKML Archive on lore.kernel.org
 help / Atom feed
* [PATCH 1/1] RAS/CEC: use the right length of "cec_disable"
@ 2017-09-03  7:54 Nicolas Iooss
  2017-09-07 20:09 ` Borislav Petkov
  2017-10-05 12:27 ` [tip:ras/urgent] RAS/CEC: Use the right length for "cec_disable" tip-bot for Nicolas Iooss
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Iooss @ 2017-09-03  7:54 UTC (permalink / raw)
  To: Borislav Petkov, Ingo Molnar, Thomas Gleixner; +Cc: linux-kernel, Nicolas Iooss

parse_cec_param() compares a string with "cec_disable" using only 7
characters of the 11-character-long string. Fix the length.

Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index d0e5d6ee882c..586c296d1538 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -523,7 +523,7 @@ int __init parse_cec_param(char *str)
 	if (*str == '=')
 		str++;
 
-	if (!strncmp(str, "cec_disable", 7))
+	if (!strncmp(str, "cec_disable", 11))
 		ce_arr.disabled = 1;
 	else
 		return 0;
-- 
2.14.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] RAS/CEC: use the right length of "cec_disable"
  2017-09-03  7:54 [PATCH 1/1] RAS/CEC: use the right length of "cec_disable" Nicolas Iooss
@ 2017-09-07 20:09 ` Borislav Petkov
  2017-10-05 12:27 ` [tip:ras/urgent] RAS/CEC: Use the right length for "cec_disable" tip-bot for Nicolas Iooss
  1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2017-09-07 20:09 UTC (permalink / raw)
  To: Nicolas Iooss; +Cc: Ingo Molnar, Thomas Gleixner, linux-kernel

On Sun, Sep 03, 2017 at 09:54:40AM +0200, Nicolas Iooss wrote:
> parse_cec_param() compares a string with "cec_disable" using only 7
> characters of the 11-character-long string. Fix the length.
> 
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
>  drivers/ras/cec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index d0e5d6ee882c..586c296d1538 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -523,7 +523,7 @@ int __init parse_cec_param(char *str)
>  	if (*str == '=')
>  		str++;
>  
> -	if (!strncmp(str, "cec_disable", 7))
> +	if (!strncmp(str, "cec_disable", 11))
>  		ce_arr.disabled = 1;
>  	else
>  		return 0;
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:ras/urgent] RAS/CEC: Use the right length for "cec_disable"
  2017-09-03  7:54 [PATCH 1/1] RAS/CEC: use the right length of "cec_disable" Nicolas Iooss
  2017-09-07 20:09 ` Borislav Petkov
@ 2017-10-05 12:27 ` tip-bot for Nicolas Iooss
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Nicolas Iooss @ 2017-10-05 12:27 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: mingo, linux-kernel, nicolas.iooss_linux, tglx, bp, hpa

Commit-ID:  69a330007091ea8a801dd9fcd897ec52f9529586
Gitweb:     https://git.kernel.org/tip/69a330007091ea8a801dd9fcd897ec52f9529586
Author:     Nicolas Iooss <nicolas.iooss_linux@m4x.org>
AuthorDate: Mon, 2 Oct 2017 11:28:35 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 5 Oct 2017 14:23:06 +0200

RAS/CEC: Use the right length for "cec_disable"

parse_cec_param() compares a string with "cec_disable" using only 7
characters of the 11-character-long string.

The proper solution for this would be:

#define CEC_DISABLE 	"cec_disable"

	strncmp(str, CEC_DISABLE, strlen(CEC_DISABLE))

but when comparing a string against a string constant strncmp() has no
advantage over strcmp() because the comparison is guaranteed to be bound by
the string constant. So just replace str strncmp() with strcmp().

[ tglx: Made it use strcmp and updated the changelog ]

Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20170903075440.30250-1-nicolas.iooss_linux@m4x.org

---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index d0e5d6e..e2c1988 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -523,7 +523,7 @@ int __init parse_cec_param(char *str)
 	if (*str == '=')
 		str++;
 
-	if (!strncmp(str, "cec_disable", 7))
+	if (!strcmp(str, "cec_disable"))
 		ce_arr.disabled = 1;
 	else
 		return 0;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-03  7:54 [PATCH 1/1] RAS/CEC: use the right length of "cec_disable" Nicolas Iooss
2017-09-07 20:09 ` Borislav Petkov
2017-10-05 12:27 ` [tip:ras/urgent] RAS/CEC: Use the right length for "cec_disable" tip-bot for Nicolas Iooss

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox