From: Jean Delvare <jdelvare@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Add missing types to checkpatch.pl --list-types
Date: Mon, 4 Sep 2017 10:03:01 +0200 [thread overview]
Message-ID: <20170904100301.4e7b1907@endymion> (raw)
In-Reply-To: <1504393085.31325.3.camel@perches.com>
On Sat, 02 Sep 2017 15:58:05 -0700, Joe Perches wrote:
> On Sat, 2017-09-02 at 23:03 +0200, Jean Delvare wrote:
> > Oh, btw, is there any purpose in listing a number in front of each
> > type?
>
> Not really. I did that because I wanted a header
> and because I had no idea how many of those types
> existed and I was too lazy to count.
Given the intended audience of the script, I think "| wc -l" is the way
to answer that question.
> > It makes it look like one can pass that number instead of the
> > type name, however it doesn't work, and I don't think it should as the
> > numbering isn't stable and could change with any update of the script.
>
> True.
>
> > Can't we simplify the output and simply print the list of type names?
>
> <shrug> If you want.
Patch coming.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2017-09-04 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 15:51 [PATCH 0/3] Add missing types to checkpatch.pl --list-types Jean Delvare
2017-09-02 15:52 ` [PATCH 1/3] checkpatch: fix typo in comment Jean Delvare
2017-09-02 15:53 ` [PATCH 2/3] checkpatch: rename variables to avoid confusion Jean Delvare
2017-09-02 15:56 ` [PATCH 3/3] checkpatch: add 6 missing types to --list-types Jean Delvare
2017-09-02 16:25 ` [PATCH 0/3] Add missing types to checkpatch.pl --list-types Joe Perches
2017-09-02 19:13 ` Jean Delvare
2017-09-02 21:03 ` Jean Delvare
2017-09-02 22:58 ` Joe Perches
2017-09-04 8:03 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904100301.4e7b1907@endymion \
--to=jdelvare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).