From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com, Ingo Molnar <mingo@redhat.com>,
Byungchul Park <byungchul.park@lge.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 2/2] tracing: Add support for critical section events
Date: Mon, 4 Sep 2017 19:34:36 -0400 [thread overview]
Message-ID: <20170904193436.4a37fae4@gandalf.local.home> (raw)
In-Reply-To: <20170904194426.GD17526@worktop.programming.kicks-ass.net>
On Mon, 4 Sep 2017 21:44:26 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > I can change the name to something else, but at the moment I can't
> > think of anything better. Could you suggest a better name? Also btw,
> > 'critical timings' is the terminology used within the irqsoff tracer
> > so this is in line with that.
>
> So 'critical section' is what some mis-guided people call the locked
> region of a lock :-) Using it for something else is prone to cause more
> confusion...
>
> I would simply call them what they are: irq_disable,irq_enable
> preempt_disable,preempt_enable.
Yes please. The "critical section" naming came from the code that was
from the latency tracer days of the real time patch (pre-ftrace). The
irqsoff tracer has the least modification from the original code, and
probably should be rewritten one of these days.
-- Steve
next prev parent reply other threads:[~2017-09-04 23:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 8:50 [PATCH 0/2] tracing: Add critical section event support Joel Fernandes
2017-09-03 8:50 ` [PATCH 1/2] tracing: irqsoff: Move code under tracer config options Joel Fernandes
2017-09-03 8:50 ` [PATCH 2/2] tracing: Add support for critical section events Joel Fernandes
2017-09-04 7:56 ` Peter Zijlstra
2017-09-04 19:04 ` Joel Fernandes
2017-09-04 19:44 ` Peter Zijlstra
2017-09-04 23:34 ` Steven Rostedt [this message]
2017-09-05 0:54 ` Joel Fernandes
2017-09-05 3:26 ` Joel Fernandes
2017-09-05 6:52 ` Peter Zijlstra
2017-09-05 16:35 ` Joel Fernandes
2017-09-06 8:40 ` Peter Zijlstra
2017-09-07 0:22 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904193436.4a37fae4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=byungchul.park@lge.com \
--cc=joelaf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).