From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdIEH2k (ORCPT ); Tue, 5 Sep 2017 03:28:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:35696 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751947AbdIEH2j (ORCPT ); Tue, 5 Sep 2017 03:28:39 -0400 Date: Tue, 5 Sep 2017 09:28:36 +0200 From: Michal Hocko To: Anshuman Khandual Cc: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, LKML Subject: Re: [PATCH] mm, sparse: fix typo in online_mem_sections Message-ID: <20170905072836.i4dxrukevojty4ub@dhcp22.suse.cz> References: <20170904112210.3401-1-mhocko@kernel.org> <4d648f70-325d-3f60-8620-94c232b380d8@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d648f70-325d-3f60-8620-94c232b380d8@linux.vnet.ibm.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 05-09-17 12:32:28, Anshuman Khandual wrote: > On 09/04/2017 04:52 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > online_mem_sections accidentally marks online only the first section in > > the given range. This is a typo which hasn't been noticed because I > > haven't tested large 2GB blocks previously. All users of > > Section sizes are normally less than 2GB. Could you please elaborate > why this never got noticed before ? Section size is 128MB which is the default block size as well. So we have one section per block. But if the amount of memory is very large (64GB - see probe_memory_block_size) then we have a 2GB memory blocks so multiple sections per block. -- Michal Hocko SUSE Labs