From: Lee Jones <lee.jones@linaro.org>
To: sathyanarayanan.kuppuswamy@linux.intel.com
Cc: souvik.k.chakravarty@intel.com, x86@kernel.org, mingo@redhat.com,
qipeng.zha@intel.com, hpa@zytor.com, dvhart@infradead.org,
tglx@linutronix.de, andy@infradead.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, sathyaosid@gmail.com
Subject: Re: [RFC v2 6/6] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls
Date: Tue, 5 Sep 2017 08:38:49 +0100 [thread overview]
Message-ID: <20170905073849.eeeo3kbncozzer46@dell> (raw)
In-Reply-To: <1504401889-113524-7-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com>
On Sat, 02 Sep 2017, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Removed redundant IPC helper functions and refactored the driver to use
> generic IPC device driver APIs.
>
> This patch also cleans-up PMC IPC user drivers to use APIs provided
> by generic IPC driver.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
> arch/x86/include/asm/intel_pmc_ipc.h | 37 +--
> drivers/mfd/intel_soc_pmic_bxtwc.c | 24 +-
> include/linux/mfd/intel_soc_pmic.h | 2 +
I'm a bit concerned by the API. Any reason why you're not using
pointers for addresses? And for the arguments where you are using
pointers, you should be using NULL, instead of 0.
> drivers/platform/x86/intel_pmc_ipc.c | 364 +++++++++-----------------
> drivers/platform/x86/intel_telemetry_pltdrv.c | 114 ++++----
> 5 files changed, 215 insertions(+), 326 deletions(-)
>
> Changes since v1:
> * Removed custom APIs.
> * Cleaned up PMC IPC user drivers to use APIs provided by generic
> IPC driver.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-09-05 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 1:24 [RFC v2 6/6] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls sathyanarayanan.kuppuswamy
2017-09-05 7:38 ` Lee Jones [this message]
2017-09-06 5:27 ` Kuppuswamy, Sathyanarayanan
2017-09-06 9:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905073849.eeeo3kbncozzer46@dell \
--to=lee.jones@linaro.org \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sathyaosid@gmail.com \
--cc=souvik.k.chakravarty@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).