From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants
Date: Tue, 5 Sep 2017 08:39:27 +0100 [thread overview]
Message-ID: <20170905073927.i7y6yhnn4tx5frtc@dell> (raw)
In-Reply-To: <20170904132242.14214-2-hdegoede@redhat.com>
On Mon, 04 Sep 2017, Hans de Goede wrote:
> Both Bay and Cherry Trail devices may be used together with a Crystal Cove
> PMIC. Each platform has its own variant of the PMIC, which both use the
> same ACPI HID, but they are not 100% compatible.
>
> This commits makes the intel_soc_pmic_core code check the _HRV of the
> ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp.
> intel_soc_pmic_config_cht_crc based on this.
>
> This fixes the Bay Trail specific ACPI OpRegion code causing problems
> on Cherry Trail devices. Specifically this was causing the external
> microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not work
> and the eMMC to become unreliable and throw lots of errors.
>
> Fixes: 5165238460 ("mfd: intel_soc_pmic: Core driver")
> Reported-and-tested-by: russianneuromancer <russianneuromancer@ya.ru>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/intel_soc_pmic_core.c | 34 ++++++++++++++++++++++++++++------
> 2 files changed, 30 insertions(+), 8 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-09-05 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 13:22 [PATCH resend 1/2] mfd: intel_soc_pmic: Export separate mfd-cell configs for BYT and CHT Hans de Goede
2017-09-04 13:22 ` [PATCH resend 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants Hans de Goede
2017-09-05 7:39 ` Lee Jones [this message]
2017-09-05 7:39 ` [PATCH resend 1/2] mfd: intel_soc_pmic: Export separate mfd-cell configs for BYT and CHT Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905073927.i7y6yhnn4tx5frtc@dell \
--to=lee.jones@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).