From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751997AbdIFHIO (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Sep 2017 03:08:14 -0400
Received: from mail-wm0-f50.google.com ([74.125.82.50]:38907 "EHLO
        mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751008AbdIFHIM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Sep 2017 03:08:12 -0400
X-Google-Smtp-Source: ADKCNb7WdQKeI3CY4E1uVI9s+9QgNCWz0vkhDFQuU31JGEIMey5K3iTdu1textXesDNWSXXkwZJHog==
Date: Wed, 6 Sep 2017 09:08:07 +0200
From: Seraphime Kirkovski <kirkseraph@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
        Shawn Lin <shawn.lin@rock-chips.com>, Pavel Machek <pavel@ucw.cz>,
        linux-mmc@vger.kernel.org
Cc: kernel list <linux-kernel@vger.kernel.org>, O@macchiaveli
Subject: 4.13 on thinkpad x220: oops when writing to SD card
Message-ID: <20170906070807.4a4t6udmlbmsaab3@macchiaveli>
Reply-To: 6689241f-a4d8-7a3e-9f0b-482b034e5710@intel.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>, Pavel Machek <pavel@ucw.cz>,
	linux-mmc@vger.kernel.org,
	kernel list <linux-kernel@vger.kernel.org>
Bcc: 
Subject: Re: 4.13 on thinkpad x220: oops when writing to SD card
Reply-To: 
In-Reply-To: <6689241f-a4d8-7a3e-9f0b-482b034e5710@intel.com>

Hi,

> > Seems 4.13-rc4 was already broken for that but unfortuantely 
> > I didn't
> > reproduce that. So maybe Seraphime can do git-bisect as he said "I get
> > it everytime" for which I assume it could be easy for him to find out
> > the problematic commit?

I can reliably reproduce it, although sometimes it needs some more work.
For example, I couldn't trigger it while writing less than 1 gigabyte
and sometimes I have to do it more than once. It helps if the machine is
doing something else in meantime, I do kernel builds.

> Another unrelated issue with mmc_init_request() is that 
> mmc_exit_request()
> is not called if mmc_init_request() fails, which means mmc_init_request()
> must free anything it allocates when it fails.

Will try the patch and report back soon.