From: Zhenhua <lizhenhuajiyang@163.com>
To: devel@acpica.org, robert.moore@intel.com, lv.zheng@intel.com,
rafael.j.wysocki@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Zhenhua <lizhenhuajiyang@163.com>
Subject: [PATCH 1/1] ACPI: NULL pointer checking
Date: Wed, 6 Sep 2017 21:35:22 +0800 [thread overview]
Message-ID: <20170906133522.7884-1-lizhenhuajiyang@163.com> (raw)
These two pointers should be checked, for some broken devices they may
cause system crash.
Signed-off-by: Zhenhua <lizhenhuajiyang@163.com>
---
drivers/acpi/acpica/nsaccess.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/nsaccess.c b/drivers/acpi/acpica/nsaccess.c
index f2733f51ca8d..151abb0ef4d5 100644
--- a/drivers/acpi/acpica/nsaccess.c
+++ b/drivers/acpi/acpica/nsaccess.c
@@ -338,7 +338,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
return_ACPI_STATUS(AE_AML_INTERNAL);
}
- if (!(flags & ACPI_NS_PREFIX_IS_SCOPE)) {
+ if ((!prefix_node) && (!(flags & ACPI_NS_PREFIX_IS_SCOPE))) {
/*
* This node might not be a actual "scope" node (such as a
* Device/Method, etc.) It could be a Package or other object
@@ -369,7 +369,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
ACPI_DEBUG_PRINT((ACPI_DB_NAMES,
"Null Pathname (Zero segments), Flags=%X\n",
flags));
- } else {
+ } else if (path) {
/*
* Name pointer is valid (and must be in internal name format)
*
--
2.14.1
next reply other threads:[~2017-09-06 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 13:35 Zhenhua [this message]
2017-09-06 16:42 ` [PATCH 1/1] ACPI: NULL pointer checking Moore, Robert
2017-09-07 19:26 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906133522.7884-1-lizhenhuajiyang@163.com \
--to=lizhenhuajiyang@163.com \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).