From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754401AbdIGJ7h (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Sep 2017 05:59:37 -0400
Received: from mail-wr0-f171.google.com ([209.85.128.171]:38169 "EHLO
        mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753881AbdIGJ7f (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Sep 2017 05:59:35 -0400
X-Google-Smtp-Source: ADKCNb7YLuc5P5W4I435EW3tZTsDDMZtuHi5u1uQ7YeNx1CXmGAfd54z3roPemMkdwdlWbR17ha1Ww==
Date: Thu, 7 Sep 2017 11:59:32 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] x86/mm: Reinitialize TLB state on hotplug and resume
Message-ID: <20170907095931.gnekqsgeelutofb4@gmail.com>
References: <cover.1504752689.git.luto@kernel.org>
 <f13c8e8c58ba3b535f1e4cb9e62b50ab37dd69bb.1504752689.git.luto@kernel.org>
 <20170907095437.fs53v7w4smhsbd6m@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170907095437.fs53v7w4smhsbd6m@pd.tnic>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@suse.de> wrote:

> > + */
> > +void initialize_tlbstate_and_flush(void)
> 
> I think we should prefix all those visible, TLB-handling functions with
> "tlb_". So you'd have tlb_init_state_and_flush().

Agreed absolutely, but note that this affects more functions as well - for example 
enter_lazy_tlb() should probably be tlb_lazy_enter() - or at least 
lazy_tlb_enter() or such?

Thanks,

	Ingo