From: Thomas Meyer <thomas@m3y3r.de>
To: shuah@kernel.org, linux-kernel@vger.kernel.org
Cc: Thomas Meyer <thomas@m3y3r.de>
Subject: [PATCH 2/2] selftests/memfd: Add null check for freepgs.
Date: Thu, 7 Sep 2017 20:36:10 +0200 [thread overview]
Message-ID: <20170907183610.27398-2-thomas@m3y3r.de> (raw)
In-Reply-To: <20170907183610.27398-1-thomas@m3y3r.de>
User mode linux kernel has no huge pages. So this variable will be null.
Guard all tests in the shell script with a null check.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
tools/testing/selftests/memfd/run_tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/memfd/run_tests.sh b/tools/testing/selftests/memfd/run_tests.sh
index daabb350697c..0b65bacf8694 100755
--- a/tools/testing/selftests/memfd/run_tests.sh
+++ b/tools/testing/selftests/memfd/run_tests.sh
@@ -46,7 +46,7 @@ fi
# If still not enough huge pages available, exit. But, give back any huge
# pages potentially allocated above.
#
-if [ $freepgs -lt $hpages_test ]; then
+if [ -n "$freepgs" ] && [ $freepgs -lt $hpages_test ]; then
# nr_hugepgs non-zero only if we attempted to increase
if [ -n "$nr_hugepgs" ]; then
echo $nr_hugepgs > /proc/sys/vm/nr_hugepages
--
2.11.0
prev parent reply other threads:[~2017-09-07 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 18:36 [PATCH 1/2] selftests/memfd: Actually make the test executable Thomas Meyer
2017-09-07 18:36 ` Thomas Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907183610.27398-2-thomas@m3y3r.de \
--to=thomas@m3y3r.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).