From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbdIGXn5 (ORCPT ); Thu, 7 Sep 2017 19:43:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:42172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbdIGXn4 (ORCPT ); Thu, 7 Sep 2017 19:43:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C08721B67 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 7 Sep 2017 19:43:52 -0400 From: Steven Rostedt To: Tom Zanussi Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com, joelaf@google.com, mathieu.desnoyers@efficios.com, baohong.liu@intel.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2 28/40] tracing: Add support for 'field variables' Message-ID: <20170907194352.7c003f7f@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Sep 2017 16:57:40 -0500 Tom Zanussi wrote: > Users should be able to directly specify event fields in hist trigger > 'actions' rather than being forced to explicitly create a variable for > that purpose. > > Add support allowing fields to be used directly in actions, which > essentially does just that - creates 'invisible' variables for each > bare field specified in an action. If a bare field refers to a field > on another (matching) event, it even creates a special histogram for > the purpose (since variables can't be defined on an existing histogram > after histogram creation). Can you show some examples here to describe what you mean better? -- Steve > > Signed-off-by: Tom Zanussi > --- > kernel/trace/trace_events_hist.c | 452 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 451 insertions(+), 1 deletion(-) > >