From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756147AbdIGVbs (ORCPT ); Thu, 7 Sep 2017 17:31:48 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:38308 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708AbdIGVbq (ORCPT ); Thu, 7 Sep 2017 17:31:46 -0400 X-Google-Smtp-Source: ADKCNb4VXLyBaC4U7pdGjLg41RifJn827cO5gIcC0bBtb61NmcSWlmnFj6Bk4S4AcJc1NShHzxVLdg== Date: Thu, 7 Sep 2017 14:31:43 -0700 From: Dmitry Torokhov To: Colin King Cc: Ulrik De Bie , KT Liao , Matti Kurkela , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: elantech: make arrays debounce_packet static, reduces object code size Message-ID: <20170907213143.GB19320@dtor-ws> References: <20170906125944.16936-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906125944.16936-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2017 at 01:59:44PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the arrays debounce_packet on the stack, instead make > them static. Makes the object code smaller by over 870 bytes: > > Before: > text data bss dec hex filename > 30553 9152 0 39705 9b19 drivers/input/mouse/elantech.o > > After: > text data bss dec hex filename > 29521 9312 0 38833 97b1 drivers/input/mouse/elantech.o > > Signed-off-by: Colin Ian King Applied, thank you. > --- > drivers/input/mouse/elantech.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > index 6428d6f4d568..b84cd978fce2 100644 > --- a/drivers/input/mouse/elantech.c > +++ b/drivers/input/mouse/elantech.c > @@ -700,7 +700,9 @@ static int elantech_debounce_check_v2(struct psmouse *psmouse) > * When we encounter packet that matches this exactly, it means the > * hardware is in debounce status. Just ignore the whole packet. > */ > - const u8 debounce_packet[] = { 0x84, 0xff, 0xff, 0x02, 0xff, 0xff }; > + static const u8 debounce_packet[] = { > + 0x84, 0xff, 0xff, 0x02, 0xff, 0xff > + }; > unsigned char *packet = psmouse->packet; > > return !memcmp(packet, debounce_packet, sizeof(debounce_packet)); > @@ -741,7 +743,9 @@ static int elantech_packet_check_v2(struct psmouse *psmouse) > static int elantech_packet_check_v3(struct psmouse *psmouse) > { > struct elantech_data *etd = psmouse->private; > - const u8 debounce_packet[] = { 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff }; > + static const u8 debounce_packet[] = { > + 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff > + }; > unsigned char *packet = psmouse->packet; > > /* > -- > 2.14.1 > -- Dmitry