From: kbuild test robot <lkp@intel.com>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: kbuild-all@01.org, rostedt@goodmis.org, tglx@linutronix.de,
mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com,
bigeasy@linutronix.de, joel.opensrc@gmail.com, joelaf@google.com,
mathieu.desnoyers@efficios.com, baohong.liu@intel.com,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH v2 40/40] tracing: Add trace_event_buffer_reserve() variant that allows recursion
Date: Fri, 8 Sep 2017 06:35:15 +0800 [thread overview]
Message-ID: <201709080638.jmFWalBM%fengguang.wu@intel.com> (raw)
In-Reply-To: <417873f6f05e44b6c93abd9771f85fa8f2dd37d0.1504642143.git.tom.zanussi@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 6803 bytes --]
Hi Tom,
[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.13 next-20170907]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tom-Zanussi/tracing-Inter-event-e-g-latency-support/20170908-054142
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All errors (new ones prefixed by >>):
kernel/trace/ring_buffer.c: In function 'rb_write_something':
>> kernel/trace/ring_buffer.c:4836:10: error: too few arguments to function 'ring_buffer_lock_reserve'
event = ring_buffer_lock_reserve(data->buffer, len);
^
kernel/trace/ring_buffer.c:2846:1: note: declared here
ring_buffer_lock_reserve(struct ring_buffer *buffer, unsigned long length,
^
vim +/ring_buffer_lock_reserve +4836 kernel/trace/ring_buffer.c
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4813)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4814) static __init int rb_write_something(struct rb_test_data *data, bool nested)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4815) {
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4816) struct ring_buffer_event *event;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4817) struct rb_item *item;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4818) bool started;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4819) int event_len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4820) int size;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4821) int len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4822) int cnt;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4823)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4824) /* Have nested writes different that what is written */
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4825) cnt = data->cnt + (nested ? 27 : 0);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4826)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4827) /* Multiply cnt by ~e, to make some unique increment */
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4828) size = (data->cnt * 68 / 25) % (sizeof(rb_string) - 1);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4829)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4830) len = size + sizeof(struct rb_item);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4831)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4832) started = rb_test_started;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4833) /* read rb_test_started before checking buffer enabled */
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4834) smp_rmb();
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4835)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 @4836) event = ring_buffer_lock_reserve(data->buffer, len);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4837) if (!event) {
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4838) /* Ignore dropped events before test starts. */
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4839) if (started) {
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4840) if (nested)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4841) data->bytes_dropped += len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4842) else
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4843) data->bytes_dropped_nested += len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4844) }
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4845) return len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4846) }
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4847)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4848) event_len = ring_buffer_event_length(event);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4849)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4850) if (RB_WARN_ON(data->buffer, event_len < len))
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4851) goto out;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4852)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4853) item = ring_buffer_event_data(event);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4854) item->size = size;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4855) memcpy(item->str, rb_string, size);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4856)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4857) if (nested) {
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4858) data->bytes_alloc_nested += event_len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4859) data->bytes_written_nested += len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4860) data->events_nested++;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4861) if (!data->min_size_nested || len < data->min_size_nested)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4862) data->min_size_nested = len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4863) if (len > data->max_size_nested)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4864) data->max_size_nested = len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4865) } else {
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4866) data->bytes_alloc += event_len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4867) data->bytes_written += len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4868) data->events++;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4869) if (!data->min_size || len < data->min_size)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4870) data->max_size = len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4871) if (len > data->max_size)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4872) data->max_size = len;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4873) }
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4874)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4875) out:
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4876) ring_buffer_unlock_commit(data->buffer, event);
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4877)
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4878) return 0;
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4879) }
6c43e554a2 Steven Rostedt (Red Hat 2013-03-15 4880)
:::::: The code at line 4836 was first introduced by commit
:::::: 6c43e554a2a5c1f2caf1733d46719bc58de3e37b ring-buffer: Add ring buffer startup selftest
:::::: TO: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
:::::: CC: Steven Rostedt <rostedt@goodmis.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51052 bytes --]
next prev parent reply other threads:[~2017-09-07 22:35 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 21:57 [PATCH v2 00/40] tracing: Inter-event (e.g. latency) support Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 01/40] tracing: Exclude 'generic fields' from histograms Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 02/40] tracing: Add support to detect and avoid duplicates Tom Zanussi
2017-09-06 18:32 ` Steven Rostedt
2017-09-06 18:47 ` Steven Rostedt
2017-09-06 20:58 ` Patel, Vedang
2017-09-05 21:57 ` [PATCH v2 03/40] tracing: Remove code which merges duplicates Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 04/40] tracing: Add hist_field_name() accessor Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 05/40] tracing: Reimplement log2 Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 06/40] ring-buffer: Add interface for setting absolute time stamps Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 07/40] tracing: Apply absolute timestamps to instance max buffer Tom Zanussi
2017-09-06 19:57 ` Steven Rostedt
2017-09-07 0:49 ` Steven Rostedt
2017-09-07 1:15 ` Liu, Baohong
2017-09-05 21:57 ` [PATCH v2 08/40] ring-buffer: Redefine the unimplemented RINGBUF_TIME_TIME_STAMP Tom Zanussi
2017-09-07 14:35 ` Steven Rostedt
2017-09-07 15:05 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 09/40] tracing: Give event triggers access to ring_buffer_event Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 10/40] tracing: Add ring buffer event param to hist field functions Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 11/40] tracing: Increase tracing map KEYS_MAX size Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 12/40] tracing: Break out hist trigger assignment parsing Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 13/40] tracing: Make traceprobe parsing code reusable Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 14/40] tracing: Add hist trigger timestamp support Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 15/40] tracing: Add per-element variable support to tracing_map Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 16/40] tracing: Add hist_data member to hist_field Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 17/40] tracing: Add usecs modifier for hist trigger timestamps Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 18/40] tracing: Add variable support to hist triggers Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 19/40] tracing: Account for variables in named trigger compatibility Tom Zanussi
2017-09-07 16:40 ` Steven Rostedt
2017-09-07 17:00 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 20/40] tracing: Add simple expression support to hist triggers Tom Zanussi
2017-09-07 16:46 ` Steven Rostedt
2017-09-07 17:01 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 21/40] tracing: Generalize per-element hist trigger data Tom Zanussi
2017-09-07 17:56 ` Steven Rostedt
2017-09-07 18:14 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 22/40] tracing: Pass tracing_map_elt to hist_field accessor functions Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 23/40] tracing: Add hist_field 'type' field Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 24/40] tracing: Add variable reference handling to hist triggers Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 25/40] tracing: Add support for dynamic tracepoints Tom Zanussi
2017-09-05 23:29 ` Mathieu Desnoyers
2017-09-06 2:35 ` Tom Zanussi
2017-09-07 22:02 ` Steven Rostedt
2017-09-08 14:18 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 26/40] tracing: Add hist trigger action hook Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 27/40] tracing: Add support for 'synthetic' events Tom Zanussi
2017-09-07 23:40 ` Steven Rostedt
2017-09-08 14:30 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 28/40] tracing: Add support for 'field variables' Tom Zanussi
2017-09-07 23:43 ` Steven Rostedt
2017-09-08 15:37 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 29/40] tracing: Add 'onmatch' hist trigger action support Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 30/40] tracing: Add 'onmax' " Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 31/40] tracing: Allow whitespace to surround hist trigger filter Tom Zanussi
2017-09-08 18:50 ` Steven Rostedt
2017-09-08 19:08 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 32/40] tracing: Add cpu field for hist triggers Tom Zanussi
2017-09-08 19:08 ` Steven Rostedt
2017-09-08 19:35 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 33/40] tracing: Add hist trigger support for variable reference aliases Tom Zanussi
2017-09-08 19:09 ` Steven Rostedt
2017-09-08 19:41 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers Tom Zanussi
2017-09-08 19:25 ` Steven Rostedt
2017-09-08 19:44 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 35/40] tracing: Reverse the order event_mutex/trace_types_lock are taken Tom Zanussi
2017-09-08 19:31 ` Steven Rostedt
2017-09-08 19:41 ` Steven Rostedt
2017-09-08 20:00 ` Steven Rostedt
2017-09-05 21:57 ` [PATCH v2 36/40] tracing: Remove lookups from tracing_map hitcount Tom Zanussi
2017-09-12 2:16 ` Masami Hiramatsu
2017-09-12 14:16 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 37/40] tracing: Add inter-event hist trigger Documentation Tom Zanussi
2017-09-20 14:44 ` Julia Cartwright
2017-09-20 17:15 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 38/40] tracing: Make tracing_set_clock() non-static Tom Zanussi
2017-09-12 2:18 ` Masami Hiramatsu
2017-09-12 14:18 ` Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 39/40] tracing: Add a clock attribute for hist triggers Tom Zanussi
2017-09-05 21:57 ` [PATCH v2 40/40] tracing: Add trace_event_buffer_reserve() variant that allows recursion Tom Zanussi
2017-09-07 22:29 ` kbuild test robot
2017-09-07 22:35 ` kbuild test robot [this message]
2017-09-08 20:27 ` Steven Rostedt
2017-09-08 20:41 ` Tom Zanussi
2017-09-12 1:50 ` [PATCH v2 00/40] tracing: Inter-event (e.g. latency) support Masami Hiramatsu
2017-09-12 14:14 ` Tom Zanussi
2017-09-19 16:31 ` Steven Rostedt
2017-09-19 18:44 ` Tom Zanussi
2017-09-21 20:20 ` Steven Rostedt
2017-09-21 21:11 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201709080638.jmFWalBM%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=baohong.liu@intel.com \
--cc=bigeasy@linutronix.de \
--cc=joel.opensrc@gmail.com \
--cc=joelaf@google.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).