linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@caviumnetworks.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] test_bitmap: Use ULL suffix for 64-bit constants
Date: Sun, 10 Sep 2017 16:33:19 +0300	[thread overview]
Message-ID: <20170910133319.urmptwfq7qifjlay@yury-thinkpad> (raw)
In-Reply-To: <1505040523-31230-1-git-send-email-geert@linux-m68k.org>

On Sun, Sep 10, 2017 at 12:48:43PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
> 
>     lib/test_bitmap.c:189: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:190: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:194: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:195: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "ULL" suffix to fix this.
> 
> Fixes: 60ef690018b262dd ("bitmap: introduce BITMAP_FROM_U64()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks.
Acked-by: Yury Norov <ynorov@caviumnetworks.com>

> ---
>  lib/test_bitmap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 599c6713f2a2aaa8..aa1f2669bdd5d836 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -186,13 +186,13 @@ static const unsigned long exp[] __initconst = {
>  	BITMAP_FROM_U64(0x22222222),
>  	BITMAP_FROM_U64(0xffffffff),
>  	BITMAP_FROM_U64(0xfffffffe),
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const unsigned long exp2[] __initconst = {
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> -- 
> 2.7.4

      reply	other threads:[~2017-09-10 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-10 10:48 [PATCH] test_bitmap: Use ULL suffix for 64-bit constants Geert Uytterhoeven
2017-09-10 13:33 ` Yury Norov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170910133319.urmptwfq7qifjlay@yury-thinkpad \
    --to=ynorov@caviumnetworks.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).