* [PATCH] procfs: remove unused variable
@ 2017-09-11 20:02 Arnd Bergmann
2017-09-12 7:43 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-09-11 20:02 UTC (permalink / raw)
To: Michal Hocko, Andrew Morton
Cc: Arnd Bergmann, Ingo Molnar, Peter Zijlstra (Intel),
Vegard Nossum, Andy Lutomirski, linux-kernel
in NOMMU configurations, we get a warning about a variable
that has become unused:
fs/proc/task_nommu.c: In function 'nommu_vma_show':
fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]
Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/proc/task_nommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
index dea90b566a6e..b00b766098fa 100644
--- a/fs/proc/task_nommu.c
+++ b/fs/proc/task_nommu.c
@@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
int is_pid)
{
struct mm_struct *mm = vma->vm_mm;
- struct proc_maps_private *priv = m->private;
unsigned long ino = 0;
struct file *file;
dev_t dev = 0;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] procfs: remove unused variable
2017-09-11 20:02 [PATCH] procfs: remove unused variable Arnd Bergmann
@ 2017-09-12 7:43 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2017-09-12 7:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Morton, Ingo Molnar, Peter Zijlstra (Intel),
Vegard Nossum, Andy Lutomirski, linux-kernel
On Mon 11-09-17 22:02:16, Arnd Bergmann wrote:
> in NOMMU configurations, we get a warning about a variable
> that has become unused:
>
> fs/proc/task_nommu.c: In function 'nommu_vma_show':
> fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]
>
> Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")
this sha doesn't exist in Linus tree. I guess it comes from linux-next.
The merged commit is 1240ea0dc3bb ("fs, proc: remove priv argument from
is_stack")
Other than that
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks for catching this and the fix!
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/proc/task_nommu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
> index dea90b566a6e..b00b766098fa 100644
> --- a/fs/proc/task_nommu.c
> +++ b/fs/proc/task_nommu.c
> @@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
> int is_pid)
> {
> struct mm_struct *mm = vma->vm_mm;
> - struct proc_maps_private *priv = m->private;
> unsigned long ino = 0;
> struct file *file;
> dev_t dev = 0;
> --
> 2.9.0
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-12 7:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-11 20:02 [PATCH] procfs: remove unused variable Arnd Bergmann
2017-09-12 7:43 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).