From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751354AbdINF1U (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Sep 2017 01:27:20 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:33837 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750770AbdINF1S (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Sep 2017 01:27:18 -0400
X-Google-Smtp-Source: AOwi7QBIbMryOboI/pMtESafnKF9G3pLRPvHB9djSG9apFrw/l62LUBo3Yj1Qt1yrR6pvGT8no5eZQ==
Date: Thu, 14 Sep 2017 07:27:14 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Don Zickus <dzickus@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sebastian Siewior <bigeasy@linutronix.de>,
        Nicholas Piggin <npiggin@gmail.com>,
        Chris Metcalf <cmetcalf@mellanox.com>,
        Ulrich Obergfell <uobergfe@redhat.com>
Subject: Re: [patch V2 25/29] lockup_detector: Implement init time detection
 of perf
Message-ID: <20170914052714.7edyt4e7uvljnpik@gmail.com>
References: <20170912193654.321505854@linutronix.de>
 <20170912194148.099799541@linutronix.de>
 <20170913180237.whri2g7soahd3ljl@redhat.com>
 <alpine.DEB.2.20.1709132004400.1874@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1709132004400.1874@nanos>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Wed, 13 Sep 2017, Don Zickus wrote:
> > > +/* Return 0, if a NMI watchdog is available. Error code otherwise */
> > > +int __weak __init void watchdog_nmi_probe(void)
> > 
> > ^^^ compile error, can't have 'int' and 'void'.  Removing 'void' fixes it.
> 
> Yes, I know. I feel stupid because I'm 100% sure that I compiled it ....

So there a Kconfig dependency on that - defconfig won't show it, which might be 
why you didn't see it?

Thanks,

	Ingo