linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Helge Deller <deller@gmx.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages
Date: Thu, 14 Sep 2017 17:03:02 +0900	[thread overview]
Message-ID: <20170914080302.GF599@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170914074044.GE599@jagdpanzerIV.localdomain>

On (09/14/17 16:40), Sergey Senozhatsky wrote:
[..]
> powerpc and parisc handle kernel .opd section as well:
> 
> arch/powerpc/kernel/vmlinux.lds.S:      .opd
> arch/parisc/kernel/vmlinux.lds.S:       .opd

for modules, arch-s define mod_arch_specific struct.

parisc has .opd

(fdesc offset should be the start of .opd,
 fdesc_offset + sizeof(fdesc) * fdesc_count should be the .opd address range)

struct mod_arch_specific
{
        unsigned long got_offset, got_count, got_max;
        unsigned long fdesc_offset, fdesc_count, fdesc_max;
        struct {
                unsigned long stub_offset;
                unsigned int stub_entries;
                } *section;
        int unwind_section;
        struct unwind_table *unwind;
};


ia64 has .opd

struct mod_arch_specific {
        struct elf64_shdr *core_plt;    /* core PLT section */
        struct elf64_shdr *init_plt;    /* init PLT section */
        struct elf64_shdr *got;         /* global offset table */
        struct elf64_shdr *opd;         /* official procedure descriptors */
        struct elf64_shdr *unwind;      /* unwind-table section */
        unsigned long gp;               /* global-pointer for module */

        void *core_unw_table;           /* core unwind-table cookie returned by unwinder */
        void *init_unw_table;           /* init unwind-table cookie returned by unwinder */
        unsigned int next_got_entry;    /* index of next available got entry */
};


powerpc does not keep track of .opd, need to add

struct mod_arch_specific {
#ifdef __powerpc64__
        unsigned int stubs_section;     /* Index of stubs section in module */
        unsigned int toc_section;       /* What section is the TOC? */
        bool toc_fixed;                 /* Have we fixed up .TOC.? */
#ifdef CONFIG_DYNAMIC_FTRACE
        unsigned long toc;
        unsigned long tramp;
#endif

#else /* powerpc64 */
        /* Indices of PLT sections within module. */
        unsigned int core_plt_section;
        unsigned int init_plt_section;
#ifdef CONFIG_DYNAMIC_FTRACE
        unsigned long tramp;
#endif
#endif /* powerpc64 */

        /* List of BUG addresses, source line numbers and filenames */
        struct list_head bug_list;
        struct bug_entry *bug_table;
        unsigned int num_bugs;
};


seems like we are looking at a solution here.

thoughts?

	-ss

  reply	other threads:[~2017-09-14  8:03 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 20:27 [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Helge Deller
2017-09-06 20:27 ` [PATCH 01/14] arm: Use %pS printk format for symbols from direct addresses Helge Deller
2017-09-06 20:27 ` [PATCH 02/14] um: " Helge Deller
2017-09-12 12:10   ` Petr Mladek
2017-09-21 20:13     ` Richard Weinberger
2017-09-06 20:27 ` [PATCH 03/14] x86: " Helge Deller
2017-09-06 20:27 ` [PATCH 04/14] ti_sci: Use %pS printk format for " Helge Deller
2017-09-08 23:30   ` Nishanth Menon
2017-09-09  0:30     ` Santosh Shilimkar
2017-09-06 20:27 ` [PATCH 05/14] i915: " Helge Deller
2017-09-27 12:24   ` [Intel-gfx] " Daniel Vetter
2017-09-06 20:27 ` [PATCH 06/14] md/bcache: " Helge Deller
2017-09-07  4:50   ` Coly Li
2017-09-07  7:42     ` Helge Deller
2017-09-07  7:49       ` Coly Li
2017-09-07  8:05       ` Sergey Senozhatsky
2017-09-06 20:27 ` [PATCH 07/14] power/avs: " Helge Deller
2017-09-08 23:37   ` Nishanth Menon
2017-09-06 20:27 ` [PATCH 08/14] fs/f2fs: " Helge Deller
2017-09-06 20:27 ` [PATCH 09/14] fs/pstore: " Helge Deller
2018-11-29 23:26   ` Kees Cook
2018-11-29 23:49     ` Luck, Tony
2018-11-30  0:40       ` Kees Cook
2017-09-06 20:27 ` [PATCH 10/14] fs/xfs: " Helge Deller
2017-09-08  7:38   ` Christoph Hellwig
2017-09-18 18:37   ` Darrick J. Wong
2017-09-06 20:27 ` [PATCH 11/14] smp: Use %pF printk format specifier for function pointers Helge Deller
2017-09-06 20:27 ` [PATCH 12/14] mm/memblock: Use %pS printk format for direct addresses Helge Deller
2017-09-06 20:28 ` [PATCH 13/14] netfilter/ipvs: " Helge Deller
2017-10-09  5:52   ` Simon Horman
2017-11-06 13:46     ` Pablo Neira Ayuso
2017-09-06 20:28 ` [PATCH 14/14] sound/core: " Helge Deller
2017-09-07  8:36   ` Takashi Iwai
2017-09-07  0:45 ` [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Sergey Senozhatsky
2017-09-07  6:01   ` Helge Deller
2017-09-07  7:56     ` Sergey Senozhatsky
2017-09-07  8:32       ` Sergey Senozhatsky
2017-09-07  9:12         ` Helge Deller
2017-09-07  9:36           ` Sergey Senozhatsky
2017-09-07  9:51             ` Sergey Senozhatsky
2017-09-07 12:38               ` Helge Deller
2017-09-07 16:05                 ` Luck, Tony
2017-09-08  6:18                   ` Sergey Senozhatsky
2017-09-08 17:25                     ` Luck, Tony
2017-09-08 18:28                       ` Helge Deller
2017-09-14  7:40                         ` Sergey Senozhatsky
2017-09-14  8:03                           ` Sergey Senozhatsky [this message]
2017-09-14  8:39                             ` Helge Deller
2017-09-14  9:27                               ` Sergey Senozhatsky
2017-09-14  9:47                                 ` Helge Deller
2017-09-14 16:01                                   ` Luck, Tony
2017-09-18  7:03                                     ` Sergey Senozhatsky
2017-09-14  6:53                       ` Sergey Senozhatsky
2017-09-08 20:49                     ` Helge Deller
2017-09-12 11:18                       ` Petr Mladek
2017-09-14  6:44                       ` Sergey Senozhatsky
2017-09-08 22:23                     ` Yu, Fenghua
2017-09-14  6:35                       ` Sergey Senozhatsky
2017-09-07 16:50                 ` Joe Perches
2017-09-08  6:23 ` Sergey Senozhatsky
2017-09-08 20:39   ` Helge Deller
2017-09-12 12:23 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170914080302.GF599@jagdpanzerIV.localdomain \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=deller@gmx.de \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).