From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbdINJA2 (ORCPT ); Thu, 14 Sep 2017 05:00:28 -0400 Received: from mout.gmx.net ([212.227.17.21]:62082 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbdINJA0 (ORCPT ); Thu, 14 Sep 2017 05:00:26 -0400 Date: Thu, 14 Sep 2017 10:59:17 +0200 From: Helge Deller To: Thomas Gleixner Cc: LKML , Ingo Molnar , Peter Zijlstra , Borislav Petkov , Andrew Morton , Sebastian Siewior , Nicholas Piggin , Don Zickus , Chris Metcalf , Ulrich Obergfell , linux-parisc@vger.kernel.org, Helge Deller Subject: Re: [patch V2 04/29] parisc: Use lockup_detector_stop() Message-ID: <20170914085917.GA24723@ls3530> References: <20170912193654.321505854@linutronix.de> <20170912194146.407385557@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170912194146.407385557@linutronix.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-Provags-ID: V03:K0:7aqR/he3kL7A1ooFY7cyKhKPxgAXoKtPOQDY/uk7AIlsHm34unK VKZGbbyuchRl3tkmsreQGq93vAU5XFKE04dsDvrW1BoobWoLixvL7W40uQLzxjLbINaKc36 Pi+fAjwne9tg36S/ZCS74Cio3VoS4eFJx7TakjchMEz7dzsVkKtLUFRJ5Uh7R2j6aw0g/9E /XWVOb5gSZbHNZowGTr1Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:LPgiLBKEFJU=:IQD+bm+aMWhlCj0E2dzx09 mTZJrBGfVGMLoqGNtyJ6Ukoovukj8NO/5MOb5CVKvThHy/40ulV6LTgbP0JeKNKLLDtu0dME1 4fTb7jU02tRoYGF1tELe8c4aEUZAsRPFkKBpOjckWX8C4Ezp7Jm0vP5Xdo8kQuYGiJqRPa2B8 msMqrPltFuXtJIyo8LQqdRPF2obQM6ZQbpRxtIMbfuLc2MDbxs8LH6IC9WVL/mtYzIVmh+EJb GZUtjU+RawmR3NT4djlRJWDD4iDjCFo6Za6K4O+A2HBxQIgiVLtj2xi4rOJ8tTjg/sSrYk2NT b3NfP8/rRgUZiGzphKs+dlzTDFea6BbT5fQuD4i0gstemLJ0BE32lpAwXZtR5eD7teuH4uXhG fsAv2jCfNC50jWS8Bg5sYhyNpobkzzOMuQXg7HRUEWXPSx4OXPHeJXuZmIG3OEaqgs8Q+j5jX L6vN7v7VTibvDkT0ui3LeDRRmwv6qaSgrIkRJD07/8ynI7ig1KLafodkD0YbhlkHYHsuUw6gb U2L0TwhblWX1MdPDwtpLPmvaa4tjsrOEKAEX4jivFssF9nKRRtHniqMIDcQCMmMFSlyjXZw4C NWikcTEAN2nsPBXnAESuCMlemZ1TCxyeDcQy/8rU9teHZb1qtnuYDTQZdGWOc0TB6E6sQQQgz LF05HypGfoVhwytK5yMZxCc2DOzkqyXYlP5J4VlRwcBV20bBSevbCg5O+4M0xhBTwjvqChd2j 4GrF01d6gcoWwMhWJvnHOtzpcmGaUVcARv7BtHnnfzhrQFw5OLO0m9j8EKaKuTmWrMuacQnhS yZpHIzBvdTqv31ufJgVcqxaqzDzXg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Thomas Gleixner : > The broken lockup_detector_suspend/resume() interface is going away. Use > the new lockup_detector_soft_poweroff() interface to stop the watchdog from > the busy looping power off routine. > > Signed-off-by: Thomas Gleixner > Cc: Don Zickus > Cc: Chris Metcalf > Cc: linux-parisc@vger.kernel.org > Cc: Peter Zijlstra > Cc: Sebastian Siewior > Cc: Nicholas Piggin > Cc: Ulrich Obergfell > Cc: Borislav Petkov > Cc: Andrew Morton > Cc: Helge Deller > Link: http://lkml.kernel.org/r/20170831073053.281414373@linutronix.de > > --- > arch/parisc/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/parisc/kernel/process.c > +++ b/arch/parisc/kernel/process.c > @@ -146,7 +146,7 @@ void machine_power_off(void) > > /* prevent soft lockup/stalled CPU messages for endless loop. */ > rcu_sysrq_start(); > - lockup_detector_suspend(); > + lockup_detector_soft_poweroff(); > for (;;); > } Thomas, thanks for cleaning that up. You may add to patches 03/04: Acked-by: Helge Deller On a side-note, there is sadly no general function like turn_off_all_kind_of_runtime_hang_detectors() which turns off *all* detectors at once (including soft lockup detector). I've seen another detector complaing at runtime that we were hanging here. I would need to dig up more info if you are interested... Helge