From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
LSM List <linux-security-module@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-ima-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
James Morris <jmorris@namei.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>, Jan Kara <jack@suse.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Bob Peterson <rpeterso@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Dave Kleikamp <shaggy@kernel.org>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
Mark Fasheh <mfasheh@versity.com>,
Joel Becker <jlbec@evilplan.org>,
Richard Weinberger <richard@nod.at>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Hugh Dickins <hughd@google.com>, Chris Mason <clm@fb.com>
Subject: Re: [PATCH 3/3] ima: use fs method to read integrity data (updated patch description)
Date: Sun, 17 Sep 2017 08:17:57 -0700 [thread overview]
Message-ID: <20170917151757.GA14262@infradead.org> (raw)
In-Reply-To: <CA+55aFxmeff53zeioTiQY6m=F18ekgX1-HWZyQUor=NJYrxM9A@mail.gmail.com>
On Sat, Sep 16, 2017 at 11:20:47AM -0700, Linus Torvalds wrote:
> Sure, generic_file_write_iter() does take that lock exclusively, but
> not everybody uses generic_file_write_iter() at all for writing.
>
> For example, xfs still uses that i_rwsem, but for block-aligned writes
> it will only get it shared. And I'm not convinced some other
> filesystem might not end up using some other lock entirely.
Only for direct I/O, and IMA and direct I/O don't work together.
>From ima_collect_measurement:
if (file->f_flags & O_DIRECT) {
audit_cause = "failed(directio)";
result = -EACCES;
goto out;
}
(and yes, it should be checking for IOCB_DIRECT to avoid racy
f_flags manipulations, but that's another issue)
> The filesystem can do its own locking, and I'm starting to think that
> it would be better to just pass this "this is an integrity read" down
> to the filesystem, and expect the filesystem to do the locking based
> on that.
Well, that's exactly the point of the new ->integrity_read routine
I proposed and prototype. The important thing is that it is called
with i_rwsem held because code mugh higher in the chain already
acquired it, but except for that it's entirely up to the file system.
next prev parent reply other threads:[~2017-09-17 15:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 4:58 [PATCH 0/3] ima: only call integrity_kernel_read to calc file hash Mimi Zohar
2017-09-15 4:58 ` [PATCH 1/3] vfs: constify path argument to kernel_read_file_from_path Mimi Zohar
2017-09-15 18:37 ` Linus Torvalds
2017-09-15 4:58 ` [PATCH 2/3] integrity: replace call to integrity_read_file with kernel version Mimi Zohar
2017-09-15 4:58 ` [PATCH 3/3] ima: use fs method to read integrity data Mimi Zohar
[not found] ` <CA+55aFwVujvsdaq09O216u-uBbBbo5i_1d6aw3ksottR_uiJ6w@mail.gmail.com>
2017-09-15 9:04 ` Mimi Zohar
2017-09-15 9:09 ` Mimi Zohar
2017-09-15 18:05 ` Linus Torvalds
2017-09-15 14:49 ` Christoph Hellwig
2017-09-15 15:21 ` Mimi Zohar
2017-09-15 20:25 ` [PATCH 3/3] ima: use fs method to read integrity data (updated patch description) Mimi Zohar
2017-09-16 18:20 ` Linus Torvalds
2017-09-17 5:47 ` Mimi Zohar
2017-09-17 15:17 ` Christoph Hellwig [this message]
2017-09-17 15:28 ` Linus Torvalds
2017-09-17 15:37 ` Christoph Hellwig
2017-09-17 16:15 ` Mimi Zohar
2017-09-17 16:34 ` Linus Torvalds
2017-09-17 16:38 ` Al Viro
2017-09-18 9:19 ` Steven Whitehouse
2017-09-18 10:13 ` Jan Kara
2017-09-18 14:55 ` Mimi Zohar
2017-09-24 22:55 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170917151757.GA14262@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mfasheh@versity.com \
--cc=mjg59@srcf.ucam.org \
--cc=richard@nod.at \
--cc=rpeterso@redhat.com \
--cc=shaggy@kernel.org \
--cc=swhiteho@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).