From: Tejun Heo <email@example.com>
To: Hans de Goede <firstname.lastname@example.org>
Cc: Matthew Garrett <email@example.com>,
Subject: Re: [PATCH] libata: Add new med_power_with_dipm link_power_management_policy setting
Date: Mon, 18 Sep 2017 20:23:42 -0700 [thread overview]
Message-ID: <20170919032341.GM378890@devbig577.frc2.facebook.com> (raw)
On Thu, Sep 14, 2017 at 12:35:36PM +0200, Hans de Goede wrote:
> As described by Matthew Garret quite a while back:
> Intel CPUs starting with the Haswell generation need SATA links to power
> down for the "package" part of the CPU to reach low power-states like
> PC7 / P8 which bring a significant power-saving with them.
> The default max_performance lpm policy does not allow for these high
> PC states, both the medium_power and min_power policies do allow this.
> The min_power policy saves significantly more power, but there are some
> reports of some disks / SSDs not liking min_power leading to system
> crashes and in some cases even data corruption has been reported.
> Matthew has found a document documenting the default settings of
> Intel's IRST Windows driver with which most laptops ship:
> Matthew wrote a patch changing med_power to match those defaults, but
> that never got anywhere as some people where reporting issues with the
> patch-set that patch was a part of.
> This commit is another attempt to make the default IRST driver settings
> available under Linux, but instead of changing medium_power and
> potentially introducing regressions, this commit adds a new
> med_power_with_dipm setting which is identical to the existing
> medium_power accept that it enables dipm on top, which makes it match
> the Windows IRST driver settings, which should hopefully be safe to
> use on most devices.
> The med_power_with_dipm setting is close to min_power, except that:
> a) It does not use host-initiated slumber mode (ASP not set),
> but it does allow device-initiated slumber
> b) It does not enable DevSlp mode
> On my T440s test laptop I get the following power savings when idle:
> medium_power 0.9W
> med_power_with_dipm 1.2W
> min_power 1.2W
> Suggested-by: Matthew Garrett <firstname.lastname@example.org>
> Cc: Matthew Garrett <email@example.com>
> Signed-off-by: Hans de Goede <firstname.lastname@example.org>
Applied to libata/for-4.15.
prev parent reply other threads:[~2017-09-19 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 10:35 [PATCH 0/1] libata: Add new med_power_with_dipm link_power_management_policy setting Hans de Goede
2017-09-14 10:35 ` [PATCH] " Hans de Goede
2017-09-19 3:23 ` Tejun Heo [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).