From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbdISS5u (ORCPT ); Tue, 19 Sep 2017 14:57:50 -0400 Received: from mail-qt0-f175.google.com ([209.85.216.175]:56406 "EHLO mail-qt0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdISS5t (ORCPT ); Tue, 19 Sep 2017 14:57:49 -0400 X-Google-Smtp-Source: AOwi7QA4umP3dSUmxYHX3Z0jPNOY/uwyFpUA71mMgT9myxFrkpQCIS8Ca+ei9RGYWNGkgmcNgywZ3g== Date: Tue, 19 Sep 2017 11:57:45 -0700 From: Tejun Heo To: Michal Hocko Cc: Tetsuo Handa , Andrew Morton , Mel Gorman , linux-mm@kvack.org, LKML Subject: Re: [PATCH] mm, memory_hotplug: do not back off draining pcp free pages from kworker context Message-ID: <20170919185745.GB828415@devbig577.frc2.facebook.com> References: <20170828093341.26341-1-mhocko@kernel.org> <20170828153359.f9b252f99647eebd339a3a89@linux-foundation.org> <6e138348-aa28-8660-d902-96efafe1dcb2@I-love.SAKURA.ne.jp> <20170829112823.GA12413@dhcp22.suse.cz> <20170831053342.fo7x4hnhicxikme4@dhcp22.suse.cz> <20170919033821.GR378890@devbig577.frc2.facebook.com> <20170919094521.2vqcnqrx3q2h2axb@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170919094521.2vqcnqrx3q2h2axb@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Sep 19, 2017 at 11:45:21AM +0200, Michal Hocko wrote: > > So, this shouldn't be an issue. This may get affected by direct > > reclaim frenzy but it's only a small piece of the whole symptom and we > > gotta fix that at the source. > > OK, so there shouldn't be any issue with the patch, right? idk, it'll make the code path more susceptible to direct reclaim starvations, so it's difficult to claim that there won't be *any* problems; however, given the extent of the starvation problem, this likely won't add any noticeable issues. Thanks. -- tejun