From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751861AbdITMTM (ORCPT <rfc822;w@1wt.eu>);
        Wed, 20 Sep 2017 08:19:12 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:60902 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751561AbdITMTL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Sep 2017 08:19:11 -0400
Date: Wed, 20 Sep 2017 13:19:07 +0100
From: Catalin Marinas <catalin.marinas@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Marc Zyngier <marc.zyngier@arm.com>, Will Deacon <will.deacon@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Olof Johansson <olof@lixom.net>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: relax assembly code alignment from 16 byte to 4
 byte
Message-ID: <20170920121907.x4jxd74tuogkb52a@localhost>
References: <1504173383-8367-1-git-send-email-yamada.masahiro@socionext.com>
 <20170907164651.3bmhdkbnxvj3pz7g@armageddon.cambridge.arm.com>
 <CAK7LNAQYDgY-4Bu9-RRLAj8hvKFXx2ctXFf058W4uQLoqpTQeg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAQYDgY-4Bu9-RRLAj8hvKFXx2ctXFf058W4uQLoqpTQeg@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 20, 2017 at 07:58:34PM +0900, Masahiro Yamada wrote:
> 2017-09-08 1:46 GMT+09:00 Catalin Marinas <catalin.marinas@arm.com>:
> > On Thu, Aug 31, 2017 at 06:56:23PM +0900, Masahiro Yamada wrote:
> >> Aarch64 instructions must be word aligned.  The current 16 byte
> >> alignment is more than enough.  Relax it into 4 byte alignment.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> ---
> >>
> >> I do not know why arm64 Linux requires 16 byte alignment.
> >>
> >> I dug git-history of arch/arm64/include/asm/linkage.h
> >> and the only commit I see is:
> >>
> >>   commit aeed41a9371ee02257b608eb06a9058507a7d0f4
> >>   Author: Marc Zyngier <Marc.Zyngier@arm.com>
> >>   Date:   Fri Oct 19 17:33:27 2012 +0100
> >>
> >>       arm64: fix alignment padding in assembly code
> >>
> >> It just opt out of the asm-generic variant to remove 0x90.
> >> So, the amount of alignment might not be not optimized yet.
> >>
> >> Please correct me if I am missing something.
> >
> > Not sure why we ended up with 4. Possibly because we forgot the power of
> > 2 difference for arm/arm64.
> >
> > Queued for 4.14. Thanks.
> 
> I still do not see this patch in linux-next.

It won't make it into linux-next now, I'll push it as a fix for -rc2
(sorry, I've been away at Plumbers and didn't get the chance to send any
pull request). I'll push the patch out on fixes/core once I investigate
some unrelated failures.

-- 
Catalin