From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Jinbum Park <jinb.park7@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"
Date: Thu, 21 Sep 2017 11:37:28 +0200 (CEST) [thread overview]
Message-ID: <20170921093729.1080368AC1@po15668-vm-win7.idsi0.si.c-s.fr> (raw)
On powerpc, RODATA_TEST fails with message the following messages:
[ 6.199505] Freeing unused kernel memory: 528K
[ 6.203935] rodata_test: test data was not read only
This is because GCC allocates it to .data section:
c0695034 g O .data 00000004 rodata_test_data
Since commit 056b9d8a76924 ("mm: remove rodata_test_data export,
add pr_fmt"), rodata_test_data is used only inside rodata_test.c
By declaring it static, it gets properly allocated into .rodata
section instead of .data:
c04df710 l O .rodata 00000004 rodata_test_data
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
mm/rodata_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/rodata_test.c b/mm/rodata_test.c
index 6bb4deb12e78..d908c8769b48 100644
--- a/mm/rodata_test.c
+++ b/mm/rodata_test.c
@@ -14,7 +14,7 @@
#include <linux/uaccess.h>
#include <asm/sections.h>
-const int rodata_test_data = 0xC3;
+static const int rodata_test_data = 0xC3;
void rodata_test(void)
{
--
2.13.3
next reply other threads:[~2017-09-21 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 9:37 Christophe Leroy [this message]
2017-09-24 19:17 ` [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Kees Cook
2017-09-25 7:37 ` Segher Boessenkool
2017-09-25 16:01 ` David Laight
2017-09-25 19:41 ` Segher Boessenkool
2017-10-02 19:29 ` Kees Cook
2017-10-02 20:08 ` Segher Boessenkool
2017-10-02 20:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921093729.1080368AC1@po15668-vm-win7.idsi0.si.c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=akpm@linux-foundation.org \
--cc=jinb.park7@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).