From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679AbdIUJhc (ORCPT ); Thu, 21 Sep 2017 05:37:32 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:3169 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdIUJhb (ORCPT ); Thu, 21 Sep 2017 05:37:31 -0400 From: Christophe Leroy Subject: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" To: Andrew Morton , Kees Cook , Jinbum Park Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Message-Id: <20170921093729.1080368AC1@po15668-vm-win7.idsi0.si.c-s.fr> Date: Thu, 21 Sep 2017 11:37:28 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On powerpc, RODATA_TEST fails with message the following messages: [ 6.199505] Freeing unused kernel memory: 528K [ 6.203935] rodata_test: test data was not read only This is because GCC allocates it to .data section: c0695034 g O .data 00000004 rodata_test_data Since commit 056b9d8a76924 ("mm: remove rodata_test_data export, add pr_fmt"), rodata_test_data is used only inside rodata_test.c By declaring it static, it gets properly allocated into .rodata section instead of .data: c04df710 l O .rodata 00000004 rodata_test_data Signed-off-by: Christophe Leroy --- mm/rodata_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/rodata_test.c b/mm/rodata_test.c index 6bb4deb12e78..d908c8769b48 100644 --- a/mm/rodata_test.c +++ b/mm/rodata_test.c @@ -14,7 +14,7 @@ #include #include -const int rodata_test_data = 0xC3; +static const int rodata_test_data = 0xC3; void rodata_test(void) { -- 2.13.3