From: Rob Herring <robh@kernel.org>
To: Ismail Kose <Ismail.Kose@maximintegrated.com>
Cc: "Ismail H. Kose" <ihkose@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
Peter Rosin <peda@axentia.se>,
Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>,
Jean-Francois Dagenais <jeff.dagenais@gmail.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Mike Looijmans <mike.looijmans@topic.nl>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] iio: dac: ds4422/ds4424 dac driver
Date: Thu, 21 Sep 2017 18:26:59 -0500 [thread overview]
Message-ID: <20170921232659.yfvdkynzlqeetuau@rob-hp-laptop> (raw)
In-Reply-To: <20170919072341.10249-1-Ismail.Kose@maximintegrated.com>
On Tue, Sep 19, 2017 at 12:23:32AM -0700, Ismail Kose wrote:
> From: "Ismail H. Kose" <ihkose@gmail.com>
>
> This patch provides an iio device driver for DS4422/DS4424 chips that support
> two/four channel 7-bit Sink/Source Current DAC.
>
> Signed-off-by: Ismail Kose <Ismail.Kose@maximintegrated.com>
> ---
> v5:
> * Removed unused variable
> v4:
> * Removed unnecessary code and space optimization
> * Alphabetic order in Kcobfig and Makefile
> v3:
> * Removed iio-map and platform file support
> * Removed ds4424.h file
> * Fixed ADC value read bug
> * Removed confused comments
> * Added device tree binding file
> * Fixed bugs in probe and read function
>
> v2:
> * Fixed coding style and removed unncessary code
> * Removed min/max rfs, ifs-scale, etc values from device tree
> * Removed unused code, definitions and some comments
> * Removed regulator control and made standard structure
> * Removed data processing and channel scale
> * Removed device tree binding file
>
> .../devicetree/bindings/iio/dac/ds4424.txt | 20 ++
It's preferred to split bindings to separate patch.
> drivers/iio/dac/Kconfig | 9 +
> drivers/iio/dac/Makefile | 1 +
> drivers/iio/dac/ds4424.c | 394 +++++++++++++++++++++
> 4 files changed, 424 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/ds4424.txt
> create mode 100644 drivers/iio/dac/ds4424.c
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/ds4424.txt b/Documentation/devicetree/bindings/iio/dac/ds4424.txt
> new file mode 100644
> index 000000000000..840b11e1d813
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ds4424.txt
> @@ -0,0 +1,20 @@
> +Maxim Integrated DS4422/DS4424 7-bit Sink/Source Current DAC Device Driver
> +
> +Datasheet publicly available at:
> +https://datasheets.maximintegrated.com/en/ds/DS4422-DS4424.pdf
> +
> +Required properties:
> + - compatible: Must be "maxim,ds4422" or "maxim,ds4424"
One compatible per line please.
> + - reg: Should contain the DAC I2C address
> + - maxim,rfs-resistors-ohms: Should contain reference resistor
...reference resistor ohms
> +
> +Optional properties:
> + - vcc-supply: Power supply is optional. If not defined, driver will ignore it.
> +
> +Example:
> + ds4224@10 {
> + compatible = "maxim,ds4424";
> + reg = <0x10>; /* When A0, A1 pins are ground */
> + vcc-supply = "dac_vcc_3v3";
This is not how the regulator binding works.
> + maxim,rfs-resistors-ohms = <400 800 1000 1600>;
The description needs to explain this is 4 values.
> + };
next prev parent reply other threads:[~2017-09-21 23:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 23:04 [PATCH] iio: dac: DS4424: add Maxim DS4422/DS4424 DAC driver support Ismail Kose
2017-06-24 17:37 ` Jonathan Cameron
2017-06-25 21:33 ` Peter Meerwald-Stadler
2017-06-26 19:56 ` Rob Herring
2017-06-29 12:47 ` Linus Walleij
2017-09-18 22:09 ` [PATCH v3] iio: dac: ds4422/ds4424 dac driver Ismail Kose
2017-09-19 4:48 ` Peter Meerwald-Stadler
2017-09-19 6:24 ` Ismail Kose
2017-09-19 7:23 ` [PATCH v5] " Ismail Kose
2017-09-21 23:26 ` Rob Herring [this message]
2017-09-22 15:09 ` Jonathan Cameron
2017-09-19 7:06 ` [PATCH v4] " Ismail Kose
2017-09-19 13:34 ` [PATCH v3] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921232659.yfvdkynzlqeetuau@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Ismail.Kose@maximintegrated.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=ihkose@gmail.com \
--cc=jeff.dagenais@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.roussinbelanger@gmail.com \
--cc=mike.looijmans@topic.nl \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).