From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934245AbdIYJQq (ORCPT ); Mon, 25 Sep 2017 05:16:46 -0400 Received: from merlin.infradead.org ([205.233.59.134]:40570 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934071AbdIYJQo (ORCPT ); Mon, 25 Sep 2017 05:16:44 -0400 Date: Mon, 25 Sep 2017 11:16:33 +0200 From: Peter Zijlstra To: Byungchul Park Cc: mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, rostedt@goodmis.org, bigeasy@linutronix.de, efault@gmx.de, max.byungchul.park@gmail.com, kernel-team@lge.com Subject: Re: [PATCH 6/7] smp/hotplug: Differentiate the AP-work lockdep class between up and down Message-ID: <20170925091633.s3mtuk3f7is5lj2e@hirez.programming.kicks-ass.net> References: <20170920170014.548896195@infradead.org> <20170920170546.922524234@infradead.org> <20170925085459.GK5994@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170925085459.GK5994@X58A-UD3R> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2017 at 05:54:59PM +0900, Byungchul Park wrote: > On Wed, Sep 20, 2017 at 07:00:20PM +0200, Peter Zijlstra wrote: > > With lockdep-crossrelease we get deadlock reports that span cpu-up and > > cpu-down chains. Such deadlocks cannot possibly happen because cpu-up > > and cpu-down are globally serialized. > > > > CPU0 CPU1 CPU2 > > cpuhp_up_callbacks: takedown_cpu: cpuhp_thread_fun: > > > > cpuhp_state > > irq_lock_sparse() > > irq_lock_sparse() > > wait_for_completion() > > cpuhp_state > > complete() > > > > Now that we have consistent AP state, we can trivially separate the > > AP-work class between up and down using st->bringup. > > Could you tell me what branch you worked the patches based on? > This is similar to the problem of workqueue so I want to fix it on > top of yours, as well. I wrote the patches on top of tip/master. Thomas maintains these bits so hopefully he'll eventually merge them in the right tip tree.