From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbdI1NuT (ORCPT ); Thu, 28 Sep 2017 09:50:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:49434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029AbdI1NuR (ORCPT ); Thu, 28 Sep 2017 09:50:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAFAC217C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org Date: Thu, 28 Sep 2017 16:50:14 +0300 From: Leon Romanovsky To: "Wei Hu (Xavier)" Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, lijun_nudt@163.com, oulijun@huawei.com, charles.chenxin@huawei.com, liuyixian@huawei.com, xushaobo2@huawei.com, zhangxiping3@huawei.com, xavier.huwei@tom.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, shaobohsu@163.com Subject: Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function Message-ID: <20170928135014.GY2297@mtr-leonro.local> References: <1506574654-56699-1-git-send-email-xavier.huwei@huawei.com> <1506574654-56699-3-git-send-email-xavier.huwei@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/iGx3h4bc2ZI981g" Content-Disposition: inline In-Reply-To: <1506574654-56699-3-git-send-email-xavier.huwei@huawei.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/iGx3h4bc2ZI981g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > It mainly places the lines for checking send doorbell status > into a special functions. As a result, we can directly call it in > check_qp_db_process_status function and keep consistent indenting > style. > > It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style) You forgot " at the end of the line, and there is need to put fixes (should be Fixes) in the line before Signed-off-by. > The warning from static checker: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status() > warn: inconsistent indenting > > Signed-off-by: Lijun Ou > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Shaobo Xu > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++-------------- > 1 file changed, 51 insertions(+), 44 deletions(-) > --/iGx3h4bc2ZI981g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlnM/hUACgkQ5GN7iDZy WKef5BAAnKTif+pcrsUgxkCeMy8XhzXOK0weAkLauqR0rzGKB4UHpR04A4qh/vTK 0Ytp3IZUDQJsn33TEmLTVP6AdWgORJjVH25/5W0XUJCIFE2kW3XNemynPfQzUKTo l3DZ9VosNF4DZdp88XC6qrYAra6qgw79jCOJ5DN9HxxFfgjzvsCWOIc+IYYJbZLl NJQeKOQJ5ztAoyODNnUHpiIig/glPfCAiD/n/kcWncjQmosFVG4OCwlx6Zez80qG R1T8gJPVPqlXJtghvLqIQyuAwrldhSO6rmgITa3X0RqExJZ7TryQPRDRmor3SB4p ESdSLq8n7AZMzDbNmdSehf3kSpcAD5H36LxY71H78YlMQpZFN6NI0GJyQqQDORnp ed6Wrd6sT6R4CJtgs2jGOYTcwK9G7wJre/vcOQBaf5iug13mNSdZYWB2a6IWACpa QKGbW6BDBd2iewLEtFmTcv74EoLRzl18AhwOCBIIBQP0+lPwZfrF6+jI5Ft/PnT2 26e+ryqA+jrEURjo7xQI4EN4qR4Ek2DJkeu43zx69429NVSBAve7M+6+lGPekouL ifHslbpA5SgfBalUKz6bK4pwX+kbwThckUHBiDCBQEbmle7LEJ2BsI+uJbUanghv 4D/+WpnBkp1MjKqJQpNKw5AB3K1IZke7eZO6KGnxT2dOt1Rz7Jw= =ksDR -----END PGP SIGNATURE----- --/iGx3h4bc2ZI981g--