From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbdI2Aup (ORCPT ); Thu, 28 Sep 2017 20:50:45 -0400 Received: from mail-by2nam01on0063.outbound.protection.outlook.com ([104.47.34.63]:45984 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751641AbdI2Auo (ORCPT ); Thu, 28 Sep 2017 20:50:44 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@cavium.com; Date: Fri, 29 Sep 2017 03:50:29 +0300 From: Yury Norov To: Volodymyr Babchuk Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org, Jens Wiklander , Volodymyr Babchuk Subject: Re: [PATCH v1 14/14] tee: shm: inline tee_shm getter functions Message-ID: <20170929005029.7kf5vros6yavrgtn@yury-thinkpad> References: <1506621851-6929-1-git-send-email-volodymyr_babchuk@epam.com> <1506621851-6929-15-git-send-email-volodymyr_babchuk@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506621851-6929-15-git-send-email-volodymyr_babchuk@epam.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [176.59.116.150] X-ClientProxiedBy: VI1PR08CA0119.eurprd08.prod.outlook.com (2603:10a6:800:d4::21) To MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b459d5e4-a347-4b4f-a377-08d506d41c5f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:MWHPR0701MB3833; X-Microsoft-Exchange-Diagnostics: 1;MWHPR0701MB3833;3:DUG2IVLjP/pQc1hzORfxm5GKY9qmzVerS6Z+Uq+jZixrSzNb7KfJa5+KzdYieXi9Av/9MiK1kuBOxRWFU99kGezcZHB12JAfuxevvonSRZTpVPYYYyDpCRwKe0xl9+m3lQFi4Twb7owS+l4x3howoWbDY9AZLGO4ZSJxFDoWRkidDAcnAV5QqLgN4zqPyzR50OTyvqSiiyU1rgsEETaf23ph1sR6nbrutK7VtINWZdedt2UQAtzfKmwFlarwiTin;25:zZ6PGqxLDhnfi5wmq6ErYY3tHeSsqupFoyRMsoeij0uDJYDflb/TK1jN6g14wIOIFr8gcBVrhVOQ3NjumImr8Mkl0nGcLUzzPO72Z2ADt7A+E2Tu8VhC85Nuh1uXdtmpaUNJeAehpAAjPw5B0H79t3GM4TXgZze6wympgtJrLvn6RerhYwQU7xHF1R+tHEikTEkYxzppfcsVNqbTCYjc/WYm9qo5DFiI9Kx3PM4nfRCojJV4JdEOVTXhweRXe6OZvxZFUR6ktnIQTS4aPK5ZdIy+XLcX2JJUb+ixxttYwYGkQ972x5In2YrA8kNupz529Ra7H+GL7fum6QjnnnfY6A==;31:Njhs+Fk3ZZp6tLsAO/0fmeEMVb91RjHRlE97hLIQ7u2ei/RzErYtyjx0dZpbHQzH+83kmRaWsdnjFQUMQtCCgvyVVbu31L4yTTS+p/74JSnpMgl9lJJNURrJhozhywe1XcjXMQZOYCJz7zQBQQfonBTVYSyFmJ8wos3siIRIdFhSyQOHUJANaU0ixNAjTCq2jxhymlDWe/lKgrLkzQ7xeygUYpvbV1Sog4N3Qg1BCaU= X-MS-TrafficTypeDiagnostic: MWHPR0701MB3833: X-Microsoft-Exchange-Diagnostics: 1;MWHPR0701MB3833;20:Dg9eYEwCrSw3OxO0CYDHUTUghHrs5adpRWwn+6TxOMWOmvN8rqRDiCPZ/JNyOVw7ahngwSHTYk1wN7aXnXE3ShXw8O6LPfrUx8sI6f5+ewG6MWgJGBZgmgn2dgaX7wVRgvQ3iGauy46JLXlxE72feLQG1OhOW+41c7nyKm+aKoml+lFLGyeWIbU7WOUQ80hHLkQ5urSbfkl1LmKIbJ9fLEU/mO+te+Wp0pHw7uMKayXpqfZcGSiJaYzduMhLNkw/sj0pni8s/HpKGpQuvTOvQGusWCd4qSzEZ3WdmlkKoi50BImukzOsqe85l5YWM3JUwzN51UzoBDyUmhWvmQMCwTmZc/eL6ot4bdiy69Ys2WGtYC5MFcXQ5Ay+HafJ/QlAtSdkpVUWoGqf2rFjSTYdrHI4sJumC3eydSoOgUMxr+eb9/33yN3vG5hWvBvcpN0BNE3+T1eqVcCvxCQBISup0onWV7dggt/254CYqZX1W8C5Aj7YBuyT10XNGGzaGbqLrL/XNVxyGS2zLqmE6FRdcTNCwNpKzmnxG4z1aUxUdjdRfSP8zYsPkPxTLWd63tmQp1G/au1hTBffQwFpc7lrB4w1sSG86O5h5T3bcYp5Iqg=;4:gmaRmEUVkU652vIlfyU0jBQnPAexEj09jfsPFcJY46ybgatt+L5gEHXwvo/CPZv0jnHiyleyFnn3a9B0XVLglReMFXL8ta/h+Fns1SJ1eQLAC5WKKTyrYAuhZhiuaBBA73CBoX0xXUJyO0QeOydQhmBJNiYX47/1qgB3+DIAw+q4iO9nq+ftga4g8Fl06K/hPWl7pmTm8AIHHUpFzlQFNct1LPkXrrFjXAP8BTHylbOeB2yI2pfQmZMLjR3icL/6 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR0701MB3833;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR0701MB3833; X-Forefront-PRVS: 0445A82F82 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(7916004)(376002)(346002)(199003)(189002)(24454002)(66066001)(6916009)(478600001)(25786009)(39060400002)(8676002)(72206003)(5660300001)(42882006)(2950100002)(8936002)(68736007)(6116002)(105586002)(81156014)(76506005)(1076002)(33646002)(106356001)(3846002)(50466002)(81166006)(23726003)(101416001)(229853002)(97736004)(16586007)(6486002)(33716001)(47776003)(6666003)(58126008)(6496005)(316002)(189998001)(4326008)(16526017)(54906003)(9686003)(53936002)(6246003)(54356999)(305945005)(83506001)(50986999)(76176999)(2906002)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR0701MB3833;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR0701MB3833;23:cyCiSLNABZQkdahwgkZaKxSJU+76x/+/1V7V1FU?= =?us-ascii?Q?AenPo8ixtYygBCPbHHVuv5IhqX9QT4K/CrPl//XYfcjTYmCKj4AiKuWOnvNZ?= =?us-ascii?Q?MbW0rmY8W9I3THTRUCKlkFKKkERXFFMX97mnP+Fn7T43aOJPQxFvV1i7N6VB?= =?us-ascii?Q?i2Od2ASs35K1l84z8I3HpyggJxdZ6lyvKe5iRUJHEXTgpngpYMHbgFxioIzE?= =?us-ascii?Q?U1jkPSOGjc/i6cvLMOkXRm4l7Fd+T3rEy3hcmrVp6GDBLtZhGmgLRrxwSnoI?= =?us-ascii?Q?jL899ckw/1EDIbwhxeu7YEOHcMJqvTNZwB/rt8mBUcqpFhmXmZvQ6bMpj3Ss?= =?us-ascii?Q?XsdmeyQzOwfSqQYCOS6Orpj+9Dtq5dOVg6O71OMLKRpQm5e8iIcPRZSAYInA?= =?us-ascii?Q?tghmPvxrFVeMds2MBnZEHfg6+SlNdP568MwWyQKGULFV3tMa1b6XbaIraM/9?= =?us-ascii?Q?xOlpoZYUdgiA2oTtQAwNmNeIpMAEnhm0X03N4QXXdD2DqtgdMwEnDGVzGQtu?= =?us-ascii?Q?leiF0GRYWZZBepnQ4XzzATb+Ph9AlTX3u3Q3/mEi2F1Hu5TfAKofnZw1d/+O?= =?us-ascii?Q?JmzqykiOW4MqSZQkaHEt6n0YivMUZ4cE7nghSDPcccKVbNvICOIVgcWr9Xxo?= =?us-ascii?Q?lfHy8Zp7KP/MChg3jNbsjBjZ670Hb7Et5HGImJ8xdhr6oUF1qnlH5jUf0QHC?= =?us-ascii?Q?CjpXgUPEt2fEX3MP84aWLErvslAQ1+mVF5qLYFvik5tosuj0GS+9DJjnqvT7?= =?us-ascii?Q?WJq6z+4a6E05le6PemMvVfKmo8YQaIbQHbImZk4Ff+dGhjOwH58pN0oI6pCW?= =?us-ascii?Q?18pVOJfhc5jem5sdMl5HiJKxdUU1YTxHC94E3YQ2OR5x1TCdfRNvKTiDX+1w?= =?us-ascii?Q?0Mrxxbf/pvFo0zu5TZsZNxZI5HTYH+l1kLH6b8JukadSIv9iHFQnIWmNeGpc?= =?us-ascii?Q?3GBK8W4c+xnE9M5qpJj0DcC3rIALBdlB4iY2E22RNNU0apaf1WP0XbUVYNhD?= =?us-ascii?Q?8xXslxfzcFtlv1QtYxVQEngaV1YMW5Csg9HXU0MZUlfole5zDleAya2sbM10?= =?us-ascii?Q?kEx15ot+1/asrw16AOBD6to2AwtygYwZ+KbEP/Na8X09GYSuq2PBNq9jARkL?= =?us-ascii?Q?JH9MPQ2kZOkP1amxNN14eYqf1BxNKpuF30rPAkWGx4l36wL5+jt8uAOKq9Hx?= =?us-ascii?Q?Pn5xV+uK2RsTUcDy7HBw5h0/4T26J8aKW9+idjF7cB+uPKFw7avi3YHXJ/X3?= =?us-ascii?Q?8DF48yFWY0GaSielFjzIegJU9gpp9Oct32jOAPkKx3oxl8yvULFPTPCXXq1p?= =?us-ascii?Q?yaA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR0701MB3833;6:2W6ZXfqn96Z3WpG3J7VYFsmyB6NV0YpIsy2/cFCxdlaFva7GC9twZaWUt0Mv2ReMkXiQEITc+PhHnojaSGRRsms0anUFljoQzQL2U+bjKhCfjz6MgKrp5bujdB9jJWRujVm8vRjyqiEEr/oD8cCq6DcKwSNRC9xhefH4/pi2QAgatO0rMrWNr83XRCbMdtJyJbS+ZGlJfg9Joq/wrYLueLWrjg7f4Iay7lxicMquDKQuRW1Rzj3Rg4Bgsw8n963tgNZzi+REOhfR/3csYXOPYPDLNakrfteR6JUP4mAjlieByQjLvbeTFcUTT12QR+osqicPXqosnhb2krNw2MWB3Q==;5:crdCnIV2gHA7oItAafwORGZohCVMOTE1eVSRhjRyNte9E+F4bqQ0BMDm58V60bk94w2ddCx5f3NI4yxOXhTqvvWc6D64wN6M1x6WOZ0ZayQLLqFAHzPern5SD2xhF8SRbwIlCy5GuJzKrrZb03VCHQ==;24:WZKxt2Nur/ZrrdAiKAZwEYYORI4cqd8uYlnZrKhpwpSMcVMBxJP3+s6CwY1+iJ2AmE10ZyUAvslWOIuJsRo5X9S6t+GOcxWVKBmgMAKlhkw=;7:qhPfoj73sIs2PdcbbtnMHdIHDd3lqUoKMz9/YtiBuG+2gAiq+TDMdaNcdsVssmfsz0tLyA5pwFWg8hiYF4WYNdWCqdZcnOaZb6KY690rIeQDOl2qN1ieulf9yZk3EOkIyn2vVdAovo3rjgvolhWDrNfPmgrjUmm5+G33l8j1b7iv9g4Dvvh9hhETlmE/jzyCfdtzl6OsCAC/BIy4M0KYWf2tgSQDwZU7r57OSo5ADFY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2017 00:50:41.5093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3833 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 28, 2017 at 09:04:11PM +0300, Volodymyr Babchuk wrote: > From: Volodymyr Babchuk > > Now, when struct tee_shm is defined in public header, > we can inline small getter functions. struct tee_shm is moved to public header in first patch of series, so you can put tee_shm_is_registered() in proper place at once, right? > > Signed-off-by: Volodymyr Babchuk > --- > drivers/tee/tee_shm.c | 17 ----------------- > include/linux/tee_drv.h | 10 ++++++++-- > 2 files changed, 8 insertions(+), 19 deletions(-) > > diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c > index 5176c83..453700a 100644 > --- a/drivers/tee/tee_shm.c > +++ b/drivers/tee/tee_shm.c > @@ -494,23 +494,6 @@ struct tee_shm *tee_shm_get_from_id(struct tee_context *ctx, int id) > } > EXPORT_SYMBOL_GPL(tee_shm_get_from_id); > > -bool tee_shm_is_registered(struct tee_shm *shm) > -{ > - return shm && (shm->flags & TEE_SHM_REGISTER); > -} > -EXPORT_SYMBOL_GPL(tee_shm_is_registered); > - > -/** > - * tee_shm_get_id() - Get id of a shared memory object > - * @shm: Shared memory handle > - * @returns id > - */ > -int tee_shm_get_id(struct tee_shm *shm) > -{ > - return shm->id; > -} > -EXPORT_SYMBOL_GPL(tee_shm_get_id); > - > /** > * tee_shm_put() - Decrease reference count on a shared memory handle > * @shm: Shared memory handle > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 6aaef65..2ae0286 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -429,7 +429,10 @@ static inline size_t tee_shm_get_page_offset(struct tee_shm *shm) > * @shm: Shared memory handle > * @returns id > */ > -int tee_shm_get_id(struct tee_shm *shm); > +static inline int tee_shm_get_id(struct tee_shm *shm) > +{ > + return shm->id; > +} > > /** > * tee_shm_get_from_id() - Find shared memory object and increase reference > @@ -445,6 +448,9 @@ struct tee_shm *tee_shm_get_from_id(struct tee_context *ctx, int id); > * @shm: Shared memory handle > * @returns true if object is registered in TEE > */ > -bool tee_shm_is_registered(struct tee_shm *shm); > +static inline bool tee_shm_is_registered(struct tee_shm *shm) > +{ > + return shm && (shm->flags & TEE_SHM_REGISTER); > +} > > #endif /*__TEE_DRV_H*/ > -- > 2.7.4