From: Rakesh Pandit <rakesh@tuxera.com>
To: "Javier González" <jg@lightnvm.io>
Cc: axboe@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 0/5] lightnvm: pblk: audit mempool usage
Date: Mon, 2 Oct 2017 20:58:52 +0300 [thread overview]
Message-ID: <20171002175851.GA6874@hercules.tuxera.com> (raw)
In-Reply-To: <1505385227-28706-1-git-send-email-javier@cnexlabs.com>
On Thu, Sep 14, 2017 at 12:33:42PM +0200, Javier González wrote:
> As suggested by Jens [1], I audited all mempools on pblk.
>
> This patche series (i) fixes bad mempool allocations that did not
> guarantee forward progress and downsizes the sizes of some overused
> mempools, (ii) removes unnecessary checks, and (iii) eliminates some
> mempools that where introduced in early versions of pblk.
All claims made above seem to be addressed in patches correctly to me.
I also did some functional testing of pblk after reviewing.
Feel free to use tag for all patches in this series even though I am
not aware of some aspects of subsystem yet. This series doesn't seem
to touch those.
Reviewed-by: Rakesh Pandit <rakesh@tuxera.com>
>
> [1] https://patchwork.kernel.org/patch/9940973/
>
> Javier González (5):
> lightnvm: pblk: fix min size for page mempool
> lightnvm: pblk: simplify work_queue mempool
> lightnvm: pblk: decouple read/erase mempools
> lightnvm: pblk: do not use a mempool for line bitmaps
> lightnvm: pblk: remove checks on mempool alloc.
>
> drivers/lightnvm/pblk-core.c | 61 ++++++++++----------------
> drivers/lightnvm/pblk-gc.c | 32 +++++++-------
> drivers/lightnvm/pblk-init.c | 94 +++++++++++++++++-----------------------
> drivers/lightnvm/pblk-read.c | 10 +----
> drivers/lightnvm/pblk-recovery.c | 37 ++++------------
> drivers/lightnvm/pblk-write.c | 32 ++++----------
> drivers/lightnvm/pblk.h | 21 +++++----
> 7 files changed, 106 insertions(+), 181 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2017-10-02 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 10:33 [PATCH 0/5] lightnvm: pblk: audit mempool usage Javier González
2017-09-14 10:33 ` [PATCH 1/5] lightnvm: pblk: fix min size for page mempool Javier González
2017-09-14 10:33 ` [PATCH 2/5] lightnvm: pblk: simplify work_queue mempool Javier González
2017-09-14 10:33 ` [PATCH 3/5] lightnvm: pblk: decouple read/erase mempools Javier González
2017-09-14 10:33 ` [PATCH 4/5] lightnvm: pblk: do not use a mempool for line bitmaps Javier González
2017-09-14 10:33 ` [PATCH 5/5] lightnvm: pblk: remove checks on mempool alloc Javier González
2017-10-02 17:58 ` Rakesh Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002175851.GA6874@hercules.tuxera.com \
--to=rakesh@tuxera.com \
--cc=axboe@fb.com \
--cc=javier@cnexlabs.com \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).