From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751477AbdJCXvv (ORCPT ); Tue, 3 Oct 2017 19:51:51 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:59648 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdJCXvu (ORCPT ); Tue, 3 Oct 2017 19:51:50 -0400 Date: Wed, 4 Oct 2017 00:51:27 +0100 From: Alan Cox To: Johannes Weiner Cc: Michal Hocko , Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: tty crash due to auto-failing vmalloc Message-ID: <20171004005127.398be9ab@alans-desktop> In-Reply-To: <20171003225504.GA966@cmpxchg.org> References: <20171003225504.GA966@cmpxchg.org> Organization: is over-rated X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I think this patch should be reverted. If somebody is vmallocing crazy > amounts of memory in the exit path we should probably track them down > individually; the patch doesn't reference any real instances of that. > But we cannot start failing allocations that have never failed before. > > That said, maybe we want Alan's N_NULL failover in the hangup path too? I think that would be best. There's always going to be a failure case even if the vmalloc change makes it rarer. Dropping back to N_NULL fixes all of the cases. Alan