From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbdJEWWD (ORCPT ); Thu, 5 Oct 2017 18:22:03 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:56660 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbdJEWWC (ORCPT ); Thu, 5 Oct 2017 18:22:02 -0400 X-Google-Smtp-Source: AOwi7QDx5JdDDJ5kecl6jJPBPEW+I1o+JiCjt/hiQotleZStAWDzADRQBdmILBDnC+Exv61cXBJa9A== From: Shakeel Butt To: Alexander Viro , Vladimir Davydov , Michal Hocko , Greg Thelen Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Shakeel Butt Subject: [PATCH] fs, mm: account filp and names caches to kmemcg Date: Thu, 5 Oct 2017 15:21:44 -0700 Message-Id: <20171005222144.123797-1-shakeelb@google.com> X-Mailer: git-send-email 2.14.2.920.gcf0c67979c-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The allocations from filp and names kmem caches can be directly triggered by user space applications. A buggy application can consume a significant amount of unaccounted system memory. Though we have not noticed such buggy applications in our production but upon close inspection, we found that a lot of machines spend very significant amount of memory on these caches. So, these caches should be accounted to kmemcg. Signed-off-by: Shakeel Butt --- fs/dcache.c | 2 +- fs/file_table.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index f90141387f01..fb3449161063 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -3642,7 +3642,7 @@ void __init vfs_caches_init_early(void) void __init vfs_caches_init(void) { names_cachep = kmem_cache_create("names_cache", PATH_MAX, 0, - SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); + SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL); dcache_init(); inode_init(); diff --git a/fs/file_table.c b/fs/file_table.c index 61517f57f8ef..567888cdf7d3 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -312,7 +312,7 @@ void put_filp(struct file *file) void __init files_init(void) { filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0, - SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL); + SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT, NULL); percpu_counter_init(&nr_files, 0, GFP_KERNEL); } -- 2.14.2.920.gcf0c67979c-goog