From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbdJHL7S (ORCPT ); Sun, 8 Oct 2017 07:59:18 -0400 Received: from mail-qk0-f171.google.com ([209.85.220.171]:45988 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbdJHL7Q (ORCPT ); Sun, 8 Oct 2017 07:59:16 -0400 X-Google-Smtp-Source: AOwi7QDtc6aFL/QL4yCKGjK2RLPFaLMGkV2wNuZafdprlIyHoSF2zvRUK/p6IicOsEAwi85RJhcpLA== Date: Sun, 8 Oct 2017 07:59:06 -0400 From: Richard Cochran To: Brandon Streiff Cc: Andrew Lunn , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Florian Fainelli , Vivien Didelot , Erik Hons Subject: Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock Message-ID: <20171008115902.xsd3a7a7fslcljdj@localhost> References: <1506612341-18061-1-git-send-email-brandon.streiff@ni.com> <1506612341-18061-3-git-send-email-brandon.streiff@ni.com> <20170928165643.GB14940@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2017 at 03:28:02PM +0000, Brandon Streiff wrote: > > NETWORK_PHY_TIMESTAMPING implies NET_PTP_CLASSIFY (which I do use) > and net/core/timestamping.c (which I didn't). It probably makes more > sense to just depend on NET_PTP_CLASSIFY directly. Yes, that makes sense to do, if you can make it work. With my driver I tried depending on NET_PTP_CLASSIFY, but there was some Kconfig issue, and rather than figuring it out I did the lazy thing and used NETWORK_PHY_TIMESTAMPING. Thanks, Richard