From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753426AbdJHPMe (ORCPT ); Sun, 8 Oct 2017 11:12:34 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:45521 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbdJHPMc (ORCPT ); Sun, 8 Oct 2017 11:12:32 -0400 X-Google-Smtp-Source: AOwi7QCi1p1RsmEsn8NLuRKhe5qVw/lMWUCqK6/Ck2y4SeBlXQBgAKrJFQAMXRJwIIgXJtqg695IAA== Date: Sun, 8 Oct 2017 11:12:29 -0400 From: Richard Cochran To: Brandon Streiff Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Andrew Lunn , Vivien Didelot , Erik Hons Subject: Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support Message-ID: <20171008151228.h75zo7wmkqvocixs@localhost> References: <1506612341-18061-1-git-send-email-brandon.streiff@ni.com> <1506612341-18061-9-git-send-email-brandon.streiff@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506612341-18061-9-git-send-email-brandon.streiff@ni.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > We also utilize a feature of the "generation 3" PTP hardware that lets > us to embed the timestamp value into one of the reserved fields in the > PTP header. This lets us extract the timestamp out of the header and > avoid an SMI access in the RX codepath. (This implementation does not > presently support the older generations.) That is fine for the later models, but we really need the code to read over MDIO as well. You added .ptp_support = true for those older switches, and so the present series won't work. If it helps, maybe I can adapt the relevant code from my driver to your work. Thanks, Richard