From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: Thomas Bogendoerfer <tbogendoerfer@suse.de>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
Date: Wed, 11 Oct 2017 18:49:14 +0300 [thread overview]
Message-ID: <20171011154914.GL2106@mtr-leonro.local> (raw)
In-Reply-To: <1d7e8d05-9a6b-6dbf-d528-41ba64129348@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote:
> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
> > Provide information about used firmware files via modinfo.
> >
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > ---
> > drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
> > index dee3c674f33d..f56ace76b42c 100644
> > --- a/drivers/infiniband/hw/hfi1/firmware.c
> > +++ b/drivers/infiniband/hw/hfi1/firmware.c
> > @@ -70,6 +70,11 @@
> > #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
> > #define HOST_INTERFACE_VERSION 1
> > +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
> > +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
> > +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
> > +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
> > +
> > static uint fw_8051_load = 1;
> > static uint fw_fabric_serdes_load = 1;
> > static uint fw_pcie_serdes_load = 1;
> >
>
> I don't find this terribly useful, but if it's useful for you I'm sure it is
> for others as well, so I have no problem with it.
Dennis,
Aren't those defines being constant?
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-11 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 12:41 [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements Thomas Bogendoerfer
2017-10-11 15:31 ` Dennis Dalessandro
2017-10-11 15:32 ` Dennis Dalessandro
2017-10-11 15:49 ` Leon Romanovsky [this message]
2017-10-11 17:13 ` Dennis Dalessandro
2017-10-11 18:10 ` Leon Romanovsky
2017-10-11 15:54 ` Thomas Bogendoerfer
2017-10-18 14:25 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011154914.GL2106@mtr-leonro.local \
--to=leon@kernel.org \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sean.hefty@intel.com \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).