LKML Archive on lore.kernel.org
 help / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: Locking API testsuite: mixed read-lock/lock-write ABBA: |FAILED|
Date: Wed, 11 Oct 2017 20:50:14 +0200
Message-ID: <20171011185014.bjtga3z6gsuigklt@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20171011112825.3c1325ac@cakuba.netronome.com>

On Wed, Oct 11, 2017 at 11:28:25AM -0700, Jakub Kicinski wrote:
> I'm seeing a failure on net-next kernels (rc4):
> 
> [    0.000000]   --------------------------------------------------------------------------
> [    0.000000]               recursive read-lock:             |  ok  |             |  ok  |
> [    0.000000]            recursive read-lock #2:             |  ok  |             |  ok  |
> [    0.000000]             mixed read-write-lock:             |  ok  |             |  ok  |
> [    0.000000]             mixed write-read-lock:             |  ok  |             |  ok  |
> [    0.000000]   mixed read-lock/lock-write ABBA:             |FAILED|             |  ok  |
> [    0.000000]    mixed read-lock/lock-read ABBA:             |  ok  |             |  ok  |
> [    0.000000]  mixed write-lock/lock-write ABBA:             |  ok  |             |  ok  |
> [    0.000000]   --------------------------------------------------------------------------
> 
> Is this OK?


Yes,

commit e91498589746065e3ae95d9a00b068e525eec34f
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Wed Aug 23 13:13:11 2017 +0200

    locking/lockdep/selftests: Add mixed read-write ABBA tests
    
    Currently lockdep has limited support for recursive readers, add a few
    mixed read-write ABBA selftests to show the extend of these
    limitations.
    
      [    0.000000] ----------------------------------------------------------------------------
      [    0.000000]                                  | spin |wlock |rlock |mutex | wsem | rsem |
      [    0.000000]   --------------------------------------------------------------------------
    
      [    0.000000]   mixed read-lock/lock-write ABBA:             |FAILED|             |  ok  |
      [    0.000000]    mixed read-lock/lock-read ABBA:             |  ok  |             |  ok  |
      [    0.000000]  mixed write-lock/lock-write ABBA:             |  ok  |             |  ok  |
    
    This clearly illustrates the case where lockdep fails to find a
    deadlock.
    
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: boqun.feng@gmail.com
    Cc: byungchul.park@lge.com
    Cc: david@fromorbit.com
    Cc: johannes@sipsolutions.net
    Cc: oleg@redhat.com
    Cc: tj@kernel.org
    Signed-off-by: Ingo Molnar <mingo@kernel.org>

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 18:28 Jakub Kicinski
2017-10-11 18:50 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011185014.bjtga3z6gsuigklt@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=kubakici@wp.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox