From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757929AbdJMKAX (ORCPT ); Fri, 13 Oct 2017 06:00:23 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:53396 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757593AbdJMKAU (ORCPT ); Fri, 13 Oct 2017 06:00:20 -0400 X-Google-Smtp-Source: ABhQp+SzYCPbUOVbWTW/rgNLdSbPnzh9Uhh6th+nh9vezpK8hGtihbrVO02eV5L2HcixnhumrDBulQ== Date: Fri, 13 Oct 2017 11:00:16 +0100 From: Lee Jones To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Marek Vasut , Rob Herring , Mark Rutland , Liam Girdwood , Mark Brown , Simon Horman , Magnus Damm , Linux-Renesas , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux PM list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power Message-ID: <20171013100016.a5s3plq7m5c6h5xo@dell> References: <1507649178-31473-1-git-send-email-geert+renesas@glider.be> <1507649178-31473-2-git-send-email-geert+renesas@glider.be> <20171013085504.i65ohil6dqdzrd2q@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Oct 2017, Geert Uytterhoeven wrote: > Hi Lee, > > On Fri, Oct 13, 2017 at 10:55 AM, Lee Jones wrote: > > On Tue, 10 Oct 2017, Geert Uytterhoeven wrote: > >> Document the new optional "rohm,ddr-backup-power" property. > >> > >> Signed-off-by: Geert Uytterhoeven > >> --- > >> Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt > >> index 9ab216a851d5619b..7ea3f2db41d4e501 100644 > >> --- a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt > >> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt > >> @@ -25,6 +25,12 @@ Required properties: > >> Each child node is defined using the standard > >> binding for regulators. > >> > >> +Optional properties: > >> + - rohm,ddr-backup-power : Value to use for DDR-Backup Power. This controls > >> + which DDR rails need to be kept powered when backup > >> + mode is enabled, cfr. the KEEPON_DDR* bits in the > > > > Perhaps it's just me, but I'm confused by this line. > > > > Can you word it another way? > > I'll ttry... Let me think a bit about it... I think it's just the "cfr" which is throwing me. > >> + documentation for the "BKUP Mode Cnt" register. > >> + > >> Example: > >> > >> pmic: pmic@30 { > >> @@ -36,6 +42,7 @@ Example: > >> #interrupt-cells = <2>; > >> gpio-controller; > >> #gpio-cells = <2>; > >> + rohm,ddr-backup-power = <15>; > > > > Can you explain what this means? Is it a mask, or does line 15 need > > to be kept on? What is the range? Is 0 acceptable? Clarification > > required please. > > It's a mask (OR of (in this case all four) needed KEEPON_DDR* bits). > Unfortunately the datasheet is not publicly available. > > 0 is acceptable, but as the property is optional, you better just leave it out. Would you mind reflecting that in the doc please? Maybe a few more examples will help? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog