From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758378AbdJMP2I (ORCPT ); Fri, 13 Oct 2017 11:28:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:33201 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481AbdJMP2H (ORCPT ); Fri, 13 Oct 2017 11:28:07 -0400 Date: Fri, 13 Oct 2017 17:28:01 +0200 From: Michal Hocko To: Christopher Lameter Cc: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K . V" , Joonsoo Kim , Guy Shattah , Anshuman Khandual , Laura Abbott , Vlastimil Babka Subject: Re: [RFC PATCH 3/3] mm/map_contig: Add mmap(MAP_CONTIG) support Message-ID: <20171013152801.nbpk6nluotgbmfrs@dhcp22.suse.cz> References: <21f1ec96-2822-1189-1c95-79a2bb491571@oracle.com> <20171012014611.18725-1-mike.kravetz@oracle.com> <20171012014611.18725-4-mike.kravetz@oracle.com> <20171012143756.p5bv4zx476qkmqhh@dhcp22.suse.cz> <20171013084054.me3kxhgbxzgm2lpr@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 13-10-17 10:20:06, Cristopher Lameter wrote: > On Fri, 13 Oct 2017, Michal Hocko wrote: [...] > > I am not really convinced this is a good interface. You are basically > > trying to bypass virtual memory abstraction and that is quite > > contradicting the mmap API to me. > > This is a standardized posix interface as described in our presentation at > the plumbers conference. See the presentation on contiguous allocations. Are you trying to desing a generic interface with a very specific and HW dependent usecase in mind? > The contiguous allocations are particularly useful for the RDMA API which > allows registering user space memory with devices. then make those devices expose an implementation of an mmap which does that. You would get both a proper access control (via fd), accounting and others. -- Michal Hocko SUSE Labs