From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757233AbdJPUOS (ORCPT ); Mon, 16 Oct 2017 16:14:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34580 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbdJPUOQ (ORCPT ); Mon, 16 Oct 2017 16:14:16 -0400 Date: Mon, 16 Oct 2017 21:14:14 +0100 (WEST) Message-Id: <20171016.211414.1286262720433234705.davem@davemloft.net> To: joe@perches.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, dsahern@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: addrconf: Use normal debugging style From: David Miller In-Reply-To: <9b7a23d78aff76a0d1e9078715e9932c9ba57b43.1508085878.git.joe@perches.com> References: <1507935733-18950-3-git-send-email-dsahern@gmail.com> <9b7a23d78aff76a0d1e9078715e9932c9ba57b43.1508085878.git.joe@perches.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Oct 2017 13:14:16 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Sun, 15 Oct 2017 09:49:10 -0700 > Remove local ADBG macro and use netdev_dbg/pr_debug > > Miscellanea: > > o Remove unnecessary debug message after allocation failure as there > already is a dump_stack() on the failure paths > o Leave the allocation failure message on snmp6_alloc_dev as there > is one code path that does not do a dump_stack() > > Signed-off-by: Joe Perches Joe please resubmit this when/if David's changes get applied.