From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935374AbdJQLeS (ORCPT ); Tue, 17 Oct 2017 07:34:18 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:29117 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbdJQLeQ (ORCPT ); Tue, 17 Oct 2017 07:34:16 -0400 Date: Tue, 17 Oct 2017 14:33:49 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: b.zolnierkie@samsung.com, tj@kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 6/8] video: fbdev: au1200fb: Remove some dead code Message-ID: <20171017113349.mee6ktysujsui7rj@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 09:04:52PM +0200, Christophe JAILLET wrote: > There is no need to shut gcc up. It should not complain. > Axe 'fbdev', it is never used in this function. > > Signed-off-by: Christophe JAILLET > --- > drivers/video/fbdev/au1200fb.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c > index e531543bc707..970ce761ff89 100644 > --- a/drivers/video/fbdev/au1200fb.c > +++ b/drivers/video/fbdev/au1200fb.c > @@ -1667,10 +1667,6 @@ static int au1200fb_drv_probe(struct platform_device *dev) > printk(DRIVER_NAME ": Panel %d %s\n", panel_index, panel->name); > printk(DRIVER_NAME ": Win %d %s\n", window_index, win->name); > > - /* shut gcc up */ > - ret = 0; Heh... It looks like they were deliberately silencing the warning about the bug you fixed in patch 2/8. :P regards, dan carpenter