From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbdJSI7B (ORCPT ); Thu, 19 Oct 2017 04:59:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45282 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbdJSI7A (ORCPT ); Thu, 19 Oct 2017 04:59:00 -0400 Date: Thu, 19 Oct 2017 10:59:07 +0200 From: Greg Kroah-Hartman To: Thomas Gleixner Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kate Stewart , Philippe Ombredanne Subject: Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/ Message-ID: <20171019085907.GA4044@kroah.com> References: <20171019083832.GA21820@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. This patch adds these > > identifiers to all files in drivers/usb/ based on a script and data from > > Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. > > > > Cc: Thomas Gleixner > > Cc: Kate Stewart > > Cc: Philippe Ombredanne > > Signed-off-by: Greg Kroah-Hartman > > --- > > Unless someone really complains, I'm going to add this to my tree for > > 4.15-rc1. > > > > > > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > > index 9650b351c26c..cb8d902b801d 100644 > > --- a/drivers/usb/Makefile > > +++ b/drivers/usb/Makefile > > @@ -1,6 +1,7 @@ > > # > > # Makefile for the kernel USB device drivers. > > # > > +# SPDX-License-Identifier: GPL-2.0 > > The last discussion about this was to add the identifier as the first line > of the file or as the second in case of files with a shebang in the first > one. > > I think you missed the last version of the script. Attached. Ugh, that's ugly, creating stuff like this: --- a/drivers/usb/atm/speedtch.c +++ b/drivers/usb/atm/speedtch.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0+ /****************************************************************************** * speedtch.c - Alcatel SpeedTouch USB xDSL modem driver * diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c Are we really ok with the '//' comments? thanks, greg k-h