From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196AbdJSPRl (ORCPT ); Thu, 19 Oct 2017 11:17:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:37552 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbdJSPRj (ORCPT ); Thu, 19 Oct 2017 11:17:39 -0400 Date: Thu, 19 Oct 2017 17:17:37 +0200 From: Jan Kara To: Arnd Bergmann Cc: y2038@lists.linaro.org, Jan Kara , Al Viro , Deepa Dinamani , linux-fsdevel@vger.kernel.org, Anders Larsen , stable@vger.kernel.org, David Howells , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] isofs: fix timestamps beyond 2027 Message-ID: <20171019151737.GC17891@quack2.suse.cz> References: <20171019144811.2144678-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171019144811.2144678-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 19-10-17 16:47:48, Arnd Bergmann wrote: > isofs uses a 'char' variable to load the number of years since > 1900 for an inode timestamp. On architectures that use a signed > char type by default, this results in an invalid date for > anything beyond 2027. > > This changes the function argument to a 'u8' array, which > is defined the same way on all architectures, and unambiguously > lets us use years until 2155. > > This should be backported to all kernels that might still be > in use by that date. > > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann ... > -int iso_date(char * p, int flag) > +int iso_date(u8 *p, int flag) > { > int year, month, day, hour, minute, second, tz; > int crtime; > > - year = p[0]; > + year = (int)(u8)p[0]; The cast seems unnecessary now? Honza -- Jan Kara SUSE Labs, CR