From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbdJVMO0 (ORCPT ); Sun, 22 Oct 2017 08:14:26 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:47296 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbdJVMOZ (ORCPT ); Sun, 22 Oct 2017 08:14:25 -0400 X-Google-Smtp-Source: ABhQp+Sn/5bBs4oaTkQbTx7VZfytQzC0NBRfsqYp6Roj7CpOjm/e5i5cSctPH3YQR6jkuY6NSuG7Pg== Date: Sun, 22 Oct 2017 14:14:21 +0200 From: Ingo Molnar To: Borislav Petkov Cc: X86 ML , Sherry Hurwitz , Yazen Ghannam , mirh@protonmail.ch, LKML Subject: Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't Message-ID: <20171022121421.ltyaj5v7qihz454y@gmail.com> References: <20171022104731.28249-1-bp@alien8.de> <20171022110438.jt3erskmxrvz52us@gmail.com> <20171022111210.2bizzpjim7dyjhdz@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171022111210.2bizzpjim7dyjhdz@pd.tnic> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote: > > Any objections to me adding a printk message that we applied a fix? > > > > pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); > > > > or so? > > > > That would also create some pressure for customers to prod manufacturers to prod > > BIOS makers to fix the erratum in a BIOS update or so. > > Adding that would be purely useless because F14h is long out of > production AFAIK. Especially those earlier models. I've still added it, just out of principle - every time the kernel modifies low level state in a rare fashion we should advertise it: pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); if it doesn't matter (which is likely as you say) then the message won't matter really. Thanks, Ingo