From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdJWPEm (ORCPT ); Mon, 23 Oct 2017 11:04:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbdJWPEl (ORCPT ); Mon, 23 Oct 2017 11:04:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A7E6B90C88 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 23 Oct 2017 17:04:36 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v5 2/6] perf record: Get the first sample time and last sample time Message-ID: <20171023150436.GA10746@krava> References: <1508542074-29483-1-git-send-email-yao.jin@linux.intel.com> <1508542074-29483-3-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508542074-29483-3-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 23 Oct 2017 15:04:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 21, 2017 at 07:27:50AM +0800, Jin Yao wrote: > In perf record, it's walked on all samples yet. So it's very easy to get > the first/last samples and save the time to perf file header via the > function write_sample_time(). > > In later, perf report/script will fetch the time from perf file header. > > Change log: > ----------- > v5: There is an issue that the sample walking can only work when > '--buildid-all' is not enabled. So we need to let the walking > be able to work even if '--buildid-all' is enabled and let the > processing skips the dso hit marking for this case. > > At first, I want to provide a new option "--record-time-boundaries". > While after consideration, I think a new option is not very > necessary. > > v3: Remove the definitions of first_sample_time and last_sample_time > from struct record and directly save them in perf_evlist. > > Signed-off-by: Jin Yao > --- > tools/perf/builtin-record.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index a6cbf16..bd711e8 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -391,8 +391,19 @@ static int process_sample_event(struct perf_tool *tool, > { > struct record *rec = container_of(tool, struct record, tool); > > - rec->samples++; > + if (rec->evlist->first_sample_time == 0) > + rec->evlist->first_sample_time = sample->time; > + > + rec->evlist->last_sample_time = sample->time; > + > + /* > + * If --buildid-all is given, it marks all DSO regardless of hits, > + * so no need to process this sample. > + */ > + if (rec->buildid_all) > + return 0; > > + rec->samples++; > return build_id__mark_dso_hit(tool, event, sample, evsel, machine); > } > > @@ -415,13 +426,6 @@ static int process_buildids(struct record *rec) > */ > symbol_conf.ignore_vmlinux_buildid = true; > > - /* > - * If --buildid-all is given, it marks all DSO regardless of hits, > - * so no need to process samples. > - */ > - if (rec->buildid_all) > - rec->tool.sample = NULL; hum, could you still unset the sample if there's no time given? and keep the speed in this case.. jirka