From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] perf, tools, record: Fix -c/-F options for cpu event aliases
Date: Tue, 24 Oct 2017 09:39:18 +0200 [thread overview]
Message-ID: <20171024073918.GB31772@krava> (raw)
In-Reply-To: <20171020202755.21410-2-andi@firstfloor.org>
On Fri, Oct 20, 2017 at 01:27:55PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> The Intel PMU event aliases have a implicit
> period= specifier to set the default period.
>
> Unfortunately this breaks overriding these periods with -c or
> -F, because the alias terms look like they are user specified
> to the internal parser, and user specified event qualifiers override
> the command line options.
>
> Track that they are coming from aliases by adding a
> "weak" state to the term. Any weak terms don't override
> command line options.
>
> I only did it for -c/-F for now, I think that's the
> only case that's broken currently.
>
> Before:
>
> $ perf record -c 1000 -vv -e uops_issued.any
> ...
> { sample_period, sample_freq } 2000003
>
> After:
>
> $ perf record -c 1000 -vv -e uops_issued.any
> ...
> { sample_period, sample_freq } 1000
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2017-10-24 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 20:27 [PATCH 1/2] perf, tools: Enable type checking for perf_evsel_config_term types Andi Kleen
2017-10-20 20:27 ` [PATCH 2/2] perf, tools, record: Fix -c/-F options for cpu event aliases Andi Kleen
2017-10-24 7:39 ` Jiri Olsa [this message]
2017-11-18 8:25 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-11-29 6:28 ` tip-bot for Andi Kleen
2017-10-24 7:38 ` [PATCH 1/2] perf, tools: Enable type checking for perf_evsel_config_term types Jiri Olsa
2017-11-08 15:40 ` Arnaldo Carvalho de Melo
2017-11-18 8:25 ` [tip:perf/core] perf evsel: " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024073918.GB31772@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).